Bugs item #1890672, was opened at 2008-02-10 17:42
Message generated for change (Settings changed) made by stmane
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=482468&aid=1890672&group_id=56967
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: SQL/Core
Group: SQL 2.22
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Stefan Manegold (stmane)
Assigned to: Niels Nes (nielsnes)
Summary: SQL/XML: implementation of and test for xmlcomment() broken?
Initial Comment:
In test sql/src/test/sql_xml/Tests/xml.sql, query
select
xmlelement(name "Customer",
xmlattributes(c.CustId as "id"),
xmlcomment('simple comment test'))
from Customers c;
produces
[ <Customer id="1"><!-- simple comment test -</Customer> ]
[ <Customer id="2"><!-- simple comment test -</Customer> ]
[ <Customer id="3"><!-- simple comment test -</Customer> ]
[ <Customer id="4"><!-- simple comment test -</Customer> ]
[ <Customer id="5"><!-- simple comment test -</Customer> ]
which is approved as correct in sql/src/test/sql_xml/Tests/xml.stable.out .
However, IMHO, this is not valid XML, and hence incorrect.
The XML comment end tags must not be "-", but rather "-->".
Hence, the correct result should IMHO be
[ <Customer id="1"><!-- simple comment test --></Customer> ]
[ <Customer id="2"><!-- simple comment test --></Customer> ]
[ <Customer id="3"><!-- simple comment test --></Customer> ]
[ <Customer id="4"><!-- simple comment test --></Customer> ]
[ <Customer id="5"><!-- simple comment test --></Customer> ]
----------------------------------------------------------------------
>Comment By: Stefan Manegold (stmane)
Date: 2008-02-15 17:01
Message:
Logged In: YES
user_id=572415
Originator: YES
Has been fixed by Niels.
Thanks.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=482468&aid=1890672&group_id=56967
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Monetdb-bugs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/monetdb-bugs
