Bugs item #1997535, was opened at 2008-06-19 09:30
Message generated for change (Comment added) made by stmane
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=482468&aid=1997535&group_id=56967
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Tests
Group: MonetDB5 5.6
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Stefan Manegold (stmane)
>Assigned to: Fabian (mr-meltdown)
Summary: M5: test src/modules/mal/Tests/remote03.mal fails
Initial Comment:
Already for some time, test
MonetDB5/src/modules/mal/Tests/remote03.mal
fails with
!MALException:remote.get:no such object ');'
!MALException:user.main[32]:Exception not catched
----------------------------------------------------------------------
>Comment By: Stefan Manegold (stmane)
Date: 2008-07-16 06:46
Message:
Logged In: YES
user_id=572415
Originator: YES
Fixed by Fabian(?).
Thanks!
----------------------------------------------------------------------
Comment By: Fabian (mr-meltdown)
Date: 2008-06-19 15:48
Message:
Logged In: YES
user_id=963970
Originator: NO
I think I found the problem. The "object name" comes from a Mapi handle,
which is closed. Hence the pointer is invalid. I now properly copy the
string, which should solve the issue.
A few questions remain:
- How can Solaris print a value
- How/why can the parser accept the garbage
I checked in my fix on the Stable branch. Mtest successfully completes
here on my system.
----------------------------------------------------------------------
Comment By: Fabian (mr-meltdown)
Date: 2008-06-19 15:37
Message:
Logged In: YES
user_id=963970
Originator: NO
Solaris shows an interesting behaviour. In contrast to all other
platforms, on Solaris a value is printed (io.print), containing "bla".
While this is certainly wrong (there is no output), the problematic part
here is that the io.print should never be called, since an exception is
thrown.
----------------------------------------------------------------------
Comment By: Stefan Manegold (stmane)
Date: 2008-06-19 15:29
Message:
Logged In: YES
user_id=572415
Originator: YES
The test fails since Wednesday June 4 2008, i.e., after checkins on
Tuesday June 3 2008.
----------------------------------------------------------------------
Comment By: Fabian (mr-meltdown)
Date: 2008-06-19 11:15
Message:
Logged In: YES
user_id=963970
Originator: NO
garbage can be passed as argument (does the parser even accept that?),
if:
str RMTget(MalBlkPtr mb, MalStkPtr stk, InstrPtr pci) {
str conn, ident, tmp;
ident = (str)getArgValue(stk, pci, 2);
if (isIdentifier(ident) < 0)
throw(ILLARG, "remote.get", "identifier expected, got '%s'",
ident);
/* perform the get */
rethrow("remote.get", tmp, RMTinternalget(c->mconn,
ident, &stk->stk[getArg(pci, 0)]));
ident in the above code is valid for isIdentifier(), but in fact garbage.
----------------------------------------------------------------------
Comment By: Fabian (mr-meltdown)
Date: 2008-06-19 11:11
Message:
Logged In: YES
user_id=963970
Originator: NO
This is the relevant code snippet:
str RMTserveget(MalBlkPtr mb, MalStkPtr stk, InstrPtr pci) {
int i;
str name;
name = (str)getArgValue(stk, pci, 1);
i = findVariable(mb, name);
if (i < 0)
throw(MAL, "remote.serveget", "no such object '%s'", name);
either, garbage was given as argument, or retrieving the first argument
(like this) doesn't work (any more).
----------------------------------------------------------------------
Comment By: Stefan Manegold (stmane)
Date: 2008-06-19 09:30
Message:
Logged In: YES
user_id=572415
Originator: YES
See, e.g.,
http://monetdb.cwi.nl/testing/projects/monetdb/Stable/MonetDB5/.mTests103/GNU.64.64.d-Fedora8/src_modules_mal/remote03.out.00.html
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=482468&aid=1997535&group_id=56967
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Monetdb-bugs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/monetdb-bugs
