Bugs item #1974965, was opened at 2008-05-27 16:22 Message generated for change (Comment added) made by stmane You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=482468&aid=1974965&group_id=56967
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Tests Group: MonetDB5 CVS Head >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Stefan Manegold (stmane) >Assigned to: Stefan Manegold (stmane) Summary: M5: tests recycle02 & recycle03 fail on Gentoo Initial Comment: MonetDB5 tests recycle02 & recycle03 in src/mal/Tests/ fail on Gentoo; looks like some "off-by-one" problem: http://monetdb.cwi.nl/testing/projects/monetdb/Stable/MonetDB5/.mTests103/GNU.32.32.d-Gentoo1.12.11.1/src_mal/recycle02.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Stable/MonetDB5/.mTests103/GNU.32.32.d-Gentoo1.12.11.1/src_mal/recycle03.out.00.html ---------------------------------------------------------------------- >Comment By: Stefan Manegold (stmane) Date: 2008-09-25 11:00 Message: Fixed --- most probably by =================================================================== 2008/09/03 - stmane: src/mal/mal_instruction.mx,1.351 src/modules/mal/recycle.mx,1.50 [ please read and learn ] Fixing general bug that (correctly!) triggered a (so far ingnored) segfault with the recycle tests on SunOS (compiler with Sun Studio compiler): It is strongly recommended NOT to use type "long" as is defined and behaves differently on different platform! In case you need a 32-bit (signed) integer type, use "int"; in case you need a 64-bit (signed) integer type, use "lng"; in case you need a type that is 32-bit on 32-bit systems and 64-bit on 64-bit systems, use "size_t" (unsigned) or "ssize_t" (signed). In particular (and this triggered the segfault) it is (obviously) not possible to use "LLFMT" as format string for values of type "long". The fix: in src/mal/mal_instruction.mx use type "int" instead of "long" for "ProfRecord.counter" (I hope 32-bit is large enough; otherwise, we should use "[s]size_t" or "lng" and adapt the remaining code and format strings accordingly...) in src/modules/mal/recycle.mx use format string "%d" (int) instead of "LLFMT" (lng) for "recycleBlk->profiler[i].counter". =================================================================== Closing. ---------------------------------------------------------------------- Comment By: Romulo Goncalves (romulog) Date: 2008-05-27 19:47 Message: Logged In: YES user_id=1498628 Originator: NO I saw that the bug was opened for stable branch... I did not realize that the current was also broken.... Thanks for the correction... ;) Romulo ---------------------------------------------------------------------- Comment By: Stefan Manegold (stmane) Date: 2008-05-27 19:09 Message: Logged In: YES user_id=572415 Originator: YES Disabling the test (in the release branch, only) does obviously NOT *fix* the bug in the development trunk. http://monetdb.cwi.nl/testing/projects/monetdb/Current/MonetDB5/.mTests103/GNU.32.32.d-Gentoo1.12.11.1/src_mal/recycle02.out.00.html http://monetdb.cwi.nl/testing/projects/monetdb/Current/MonetDB5/.mTests103/GNU.32.32.d-Gentoo1.12.11.1/src_mal/recycle03.out.00.html ---------------------------------------------------------------------- Comment By: Romulo Goncalves (romulog) Date: 2008-05-27 18:55 Message: Logged In: YES user_id=1498628 Originator: NO These test should not be executed on the stable branch... I already deactivated these tests so I think the bug can be closed... Stefan if you do not agree, just open it again ;) Romulo ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=482468&aid=1974965&group_id=56967 ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Monetdb-bugs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/monetdb-bugs
