Bugs item #2825974, was opened at 2009-07-23 15:15
Message generated for change (Comment added) made by skinkie
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=482468&aid=2825974&group_id=56967

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: SQL/Core
Group: SQL CVS Head
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Stefan de Konink (skinkie)
Assigned to: Niels Nes (nielsnes)
Summary: select * where bla = "whatever" crashes

Initial Comment:
Some of our 'friendly' webservice users tried MonetDB in a somewhat disturbing 
way, resulting in a segmentation fault of the server. The query in the subject 
will reproduce it from mclient as well.

----------------------------------------------------------------------

>Comment By: Stefan de Konink (skinkie)
Date: 2009-07-31 07:08

Message:
selection->h is not available with broken queries, must be explicitly
checked before use. Removes void cast of where because the variable is in
use.

The origin of the problem was a user entering a malformed query on my
webinterface that segfaulted monet. The patch implements a null check to
prevent n->* to be used.

----------------------------------------------------------------------

Comment By: Stefan Manegold (stmane)
Date: 2009-07-31 05:59

Message:
Would it be possible to provide a context diff to ensure correct automatic
application (or prevent incorrect application automatic application) even
in case the original code base has changed in the meantime?

Would it be possible to provide the context diff in unified format to
improve human readability?
(admittedly personal taste)

Would it be possible to explain/document the details of the patch, and
hence enlighten us what the origin of the actual problem was, and how it
has been solved?

Thank you very much in advance!


----------------------------------------------------------------------

Comment By: Stefan de Konink (skinkie)
Date: 2009-07-23 16:35

Message:
The attached file basically prevents the crash, but I wonder if we can
solve it higher in the tree. Output now is:

sql>select * where bla = "whatever";
!SELECT: identifier 'bla' unknown
0 tuples

So that looks good :)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=482468&aid=2825974&group_id=56967

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Monetdb-bugs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/monetdb-bugs

Reply via email to