Bugs item #2607229, was opened at 2009-02-17 00:02
Message generated for change (Comment added) made by stmane
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=482468&aid=2607229&group_id=56967
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core
Group: MonetDB Common "stable"
Status: Open
Resolution: None
Priority: 9
Private: No
Submitted By: Stefan Manegold (stmane)
Assigned to: Martin Kersten (mlkersten)
Summary: testing does not report detected property errors
Initial Comment:
Since this checkin
===================================================================
2008/10/25 - mlkersten: MonetDB/src/gdk/gdk_bat.mx,1.204
Most of the changes are related to moving GDKwarning into proper
debugging statements.
The major change is in gdk_utils, where the failure to vtrim does not
lead to a system crash anymore. It is properly retained in the errbuf
for the upper layers to consume.
===================================================================
(cf.,
`cd .../MonetDB &&
cvs diff -r1.20{3,4} src/gdk/gdk_bat.mx`)
BATpropcheck no longer reports incorrect BAT properties as ('!'-prefixed)
GDKwarning, but rather as simple '#'-prefixed comments.
Since the latter are (for good reasons) ignored by testing (Mdiff), testing
does no longer report incorrect BAT properties as detected by BATpropcheck.
Consequently, property errors can silently sneak into tests unnoticed, and have
indeed done so, e.g., look for "BATprocheck:" at
http://monetdb.cwi.nl/testing/projects/monetdb/Stable/sql/.mTests103/Int.64.64.d.1-Fedora8/src_test_bugs/rangejoin_optimize_bug.out.00.html
http://monetdb.cwi.nl/testing/projects/monetdb/Stable/pathfinder/.mTestsg103/GNU.64.64.d.1-Fedora8/tests_BugTracker/pf-O0_produces_wrong_MIL.SF-1771532.out.00.html
----------------------------------------------------------------------
>Comment By: Stefan Manegold (stmane)
Date: 2009-07-31 22:15
Message:
Mtest.py / Mfilter.py now recognize BATpropcheck messages in any case and
treats them as error.
IMHO, incorrectly set properties are errors, and should hence also be
reported as such, in case they are detected, i.e., when property checking
is explicitly enabled (e.g., during testing and debugging) ...
----------------------------------------------------------------------
Comment By: Martin Kersten (mlkersten)
Date: 2009-07-31 21:39
Message:
Would it be a solution to mark them as #!, which means that the test
analysis scripts look a little further.
----------------------------------------------------------------------
Comment By: Stefan Manegold (stmane)
Date: 2009-02-22 09:57
Message:
see also
[ 2627138 ] SQL: test fails with BATpropcheck error
https://sourceforge.net/tracker/index.php?func=detail&aid=2627138&group_id=56967&atid=482468
and
[ 2627137 ] PF: tests fail with BATpropcheck error
https://sourceforge.net/tracker/index.php?func=detail&aid=2627137&group_id=56967&atid=482468
----------------------------------------------------------------------
Comment By: Stefan Manegold (stmane)
Date: 2009-02-21 20:12
Message:
Since correct handling of properties is not that unimportant for MonetDB, I
made testing treat property inconsistencies as reported by BATpropcheck as
errors, again, regardless of whether BATpropcheck reports them as errors or
as comments.
Details to be seen as of tomorrows' testing results.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=482468&aid=2607229&group_id=56967
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Monetdb-bugs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/monetdb-bugs
