Feature Requests item #923204, was opened at 2004-03-25 16:53
Message generated for change (Settings changed) made by mlkersten
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=482471&aid=923204&group_id=56967

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Priority: 5
Private: No
Submitted By: Marcin Zukowski (e-r00)
Assigned to: Nobody/Anonymous (nobody)
Summary: Making Mapi.h more C friendly

Initial Comment:
We should at least:
- get rid of #line statements
- have comments inside .h


----------------------------------------------------------------------

>Comment By: Martin Kersten (mlkersten)
Date: 2009-12-04 16:26

Message:
No action to be taken on this one anymore.

----------------------------------------------------------------------

Comment By: Marcin Zukowski (e-r00)
Date: 2004-09-15 16:27

Message:
Logged In: YES 
user_id=607094

It seems that nobody really noticed adding -l switch to .h
creation rule.
Good :)
Still, currently the rule system makes everything recompile
even if I only touch .mx file containing .h.
The reason is, .h rule doesn't contain -n switch (don't
touch unchanged files) for Mx.
I suggest adding -n to .h and possibly also other rules (.c
.y and so on).


----------------------------------------------------------------------

Comment By: Sjoerd Mullender (sjoerd)
Date: 2004-08-19 11:26

Message:
Logged In: YES 
user_id=43607

We should not confuse matters.  The original request is to
remove #line directives from Mapi.h.  More generally,
removing them from all .h files should be no problem.  Since
there is (or certainly: should) not be any executable code
in .h files, #line directives don't do anything for the
debugger.

As to comments in Mapi.h, definitely!  The whole Mapi.mx
documentation should be redone.

----------------------------------------------------------------------

Comment By: Martin Kersten (mlkersten)
Date: 2004-03-25 21:10

Message:
Logged In: YES 
user_id=490798

The #line statements are needed to keep track of the
location when you are running with a debugger/profiler.
Droppping #line could mean there is not enough documentation.

In the rare cases #line was a stand in the way I took the c-file
and deleted the lines with a simple edit command

----------------------------------------------------------------------

Comment By: Stefan Manegold (stmane)
Date: 2004-03-25 20:25

Message:
Logged In: YES 
user_id=572415

Just no to forget this:

Both, Martin and Marcin are right (which is not too
supprisingly, since there names differ by only one character
... ;-):
Yes, #line statments are needed for debugging as long as the
originaly .mx file is still available, i.e., during "make"
in the build directory.
After "make install" (or "make rpm") however, the .mx file
is gone, and then the #line statements are actually "wrong"
and "hinder" convenient debugging.
Hence, the core of this feature request boils down to 
- remove #line statements from header files during "make
install"
- make sure that there is (some) documentation left in .h
files after they got extracted from a .mx file.

[Quite busy here for a low-priority feature request ... ;-)]


----------------------------------------------------------------------

Comment By: Marcin Zukowski (e-r00)
Date: 2004-03-25 20:05

Message:
Logged In: YES 
user_id=607094

I only want #line removed from .h files provided for external users, e.g.

Mapi.h.
I'm pretty sure one day there will be a need for separate distribution of

libMapi and libMapi-dev (e.g. to compile MonetDB PHP client ;)), and then
it 
would be handy.
It's not urgent though :)


----------------------------------------------------------------------

Comment By: Martin Kersten (mlkersten)
Date: 2004-03-25 19:54

Message:
Logged In: YES 
user_id=490798

The #line statements are needed to keep track of the
location when you are running with a debugger/profiler.
Droppping #line could mean there is not enough documentation.

In the rare cases #line was a stand in the way I took the c-file
and deleted the lines with a simple edit command

----------------------------------------------------------------------

Comment By: Marcin Zukowski (e-r00)
Date: 2004-03-25 18:59

Message:
Logged In: YES 
user_id=607094

Indeed, -l would be just enough, but I don't how to add the switch only
for 
creation of this file.

----------------------------------------------------------------------

Comment By: Stefan Manegold (stmane)
Date: 2004-03-25 18:20

Message:
Logged In: YES 
user_id=572415

- get rid of #line statements:

What about using "Mx -l"? ;-)

18:19:35 maneg...@draco:~/Monet/4.3.16/MonetDB $ Mx
Usage: Mx <flags> <file>.mx.
        -t              Produce LaTeX document (default).
        -c              Extract code.
        -R <dir>        Set target directory to <dir>).
        -S <style>      Set LaTeX documentstyle to 'style'.
        -s              Produce nroff -ms document.
        -1              Single column (default) .
        -2              Double column.
        -H <n>          Set hide level to 'n' (-H0 default).
        -d              Produce a draft document.
        -x <extension>  Extract <extension> labelled code.
        -w              Extract HTML code.
        -D <id>         Define macro 'id'.
        -T <string>     Define default hide text <string>.
        -l              No #line and alike statements.
        -n              Non changed files won't be touched.
        -+              Treat @c (C code) as @C (C++ code).
18:19:52 maneg...@draco:~/Monet/4.3.16/MonetDB $ 


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=482471&aid=923204&group_id=56967

------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing. 
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev
_______________________________________________
Monetdb-bugs mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/monetdb-bugs

Reply via email to