Bugs item #2963916, was opened at 2010-03-04 22:28 Message generated for change (Comment added) made by mbucc You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=482468&aid=2963916&group_id=56967
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: SQL/Core Group: SQL "stable" Status: Open Resolution: None Priority: 5 Private: No Submitted By: Mark Bucciarelli (mbucc) Assigned to: Fabian (mr-meltdown) Summary: sizeof a pointer passed to snprintf Initial Comment: Hi, This is with Feb2010 branch. The second argument to the snprintf() call in generatePassphraseFile() was taking sizeof a pointer. This patch fixes this issue, as well as a couple other issues with the routine, namely: * fopen() return value was not checked * strdup() return value was not checked You may not agree with the way I handle these errors (crash immediately), but I wasn't sure how important this routine is. (In general I have found it productive to crash early and crash hard.) A quick grep turned up another couple instances where fopen's return value was not checked around line 125 of monet5/merovingian/databaase.c. That routine also has lots of strdup's with no return value check. (Not that it matters on Linux ... where calloc() _always_ returns non-NULL.) ---------------------------------------------------------------------- Comment By: Mark Bucciarelli (mbucc) Date: 2010-03-05 07:53 Message: I'm not sure what you are asking for. I attached patch for one. I referenced one other spot in the description with the filename and line #. ---------------------------------------------------------------------- Comment By: Fabian (mr-meltdown) Date: 2010-03-05 04:29 Message: I think these are bits in my code, can you report exactly which files these are in? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=482468&aid=2963916&group_id=56967 ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Monetdb-bugs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/monetdb-bugs
