On Tue, May 29, 2007 at 11:45:48AM +0200, Fabian Groffen wrote:
> On 29-05-2007 09:38:05 +0000, Martin Kersten wrote:
> > Update of /cvsroot/monetdb/MonetDB5/src/tools
> > In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv493
> >
> > Modified Files:
> > mguardian monetdb
> > Log Message:
> > The scripts have been patched by Alexandru Toth to make it
> > work on MAC OS and FreeBSD
>
> > --- monetdb 25 May 2007 08:40:42 -0000 1.42
> > +++ monetdb 29 May 2007 09:38:02 -0000 1.43
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/env bash
> > +#!/bin/bash
>
> on AIX bash lives in /usr/bin/bash, so better leave this /usr/bin/env as
> it was.
right.
... or turn it into a .in file and use the @BASH@ that configure finds ...
Stefan
> > # The contents of this file are subject to the MonetDB Public License
> > # Version 1.1 (the "License"); you may not use this file except in
> > # compliance with the License. You may obtain a copy of the License at
> > @@ -43,52 +43,52 @@
> >
> > ASCII=""
> > DBFARM=$MONETDB5_PREFIX/var/MonetDB5/dbfarm
> > +DBLOGS=$MONETDB5_PREFIX/var/MonetDB5/dblogs
> > # First perform some sanity checks
> > -if [[ -z $MONETDB5_PREFIX ]] ; then
> > +if [ "$MONETDB5_PREFIX" = "" ]
> > +then
>
> If you have bash, why not use it?
>
> > echo "The MONETDB5_PREFIX environment variable has not been set"
> > - echo "It should point to the directory where you have installed MonetDB"
> > + echo "It should point to where you have installed the build directory"
>
> vague.
>
> > -# emit a warning :)
> > -echo " * warning: This script is experimental"
>
> this warning was useful in this state of the script.
>
> > - STARTUP=${TMPDIR:-/var/tmp}/mserver5.startup$$
> > + STARTUP=/tmp/mserver5.startup$$
>
> Don't write in /tmp if TMPDIR is defined. Also, preferably write in
> /var/tmp, as /tmp might be your swapspace.
>
> > +if [ ! -d $DBLOGS ]
> > +then
> > + echo "Creation of missing database storage area '$DBFARM'"
> > + mkdir -p $DBLOGS
> > +fi
>
> Why is this necessary? Doesn't MonetDB do this itself?
>
> > - if [ ! -f $1/.monetdb.conf ]
> > + if [ ! -f $DBFARM/$1/.monetdb.conf ]
>
> What if $DBFARM or $1 contains spaces? [[ ]] helps you out here.
>
> > - ARGS=`cat $1/.mserver5.args`
> > + ARGS=`cat $DBFARM/$1/.mserver5.args`
>
> Since you're using bash: ARGS=$(<$DBFARM/$1/.mserver5.args) ?
>
> > --- mguardian 25 May 2007 08:41:50 -0000 1.23
> > +++ mguardian 29 May 2007 09:38:02 -0000 1.24
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/env bash
> > +#!/bin/bash
>
> idem
>
> (not checked any further)
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Monetdb-checkins mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
>
--
| Dr. Stefan Manegold | mailto:[EMAIL PROTECTED] |
| CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ |
| 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 |
| The Netherlands | Fax : +31 (20) 592-4312 |
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Monetdb-checkins mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/monetdb-checkins
