Update of /cvsroot/monetdb/clients/src/php/Cimpl
In directory 
sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv22004/clients/src/php/Cimpl

Modified Files:
      Tag: Clients_1-20
        Makefile.ag 
Log Message:

since compilation with strict compiler settings have (once again)
proved to be bery useful to locate bugs in the code,
we nolonger simply disable all of the strict "X_CFLAGS"
in directories that (also) contain swig-code,
but rather selectively disable only those extra warnings/errors
that do indeed occur in code that is beyond our control.

(This affects only compilation with --enable-strict.)


Index: Makefile.ag
===================================================================
RCS file: /cvsroot/monetdb/clients/src/php/Cimpl/Makefile.ag,v
retrieving revision 1.4.4.1
retrieving revision 1.4.4.2
diff -u -d -r1.4.4.1 -r1.4.4.2
--- Makefile.ag 2 Oct 2007 11:49:36 -0000       1.4.4.1
+++ Makefile.ag 6 Nov 2007 11:55:46 -0000       1.4.4.2
@@ -22,10 +22,24 @@
 # we need this flag to allow for a name that does not start with "lib"
 monetdb_la_LDFLAGS = -module
 
-# with gcc we could use these
-#X_CFLAGS = -Wno-unused-parameter -Wno-unused-function
-# but we certainly have to override the default X_CFLAGS:
-X_CFLAGS = -DCOMPILE_DL_MONETDB=1 -D_GNU_SOURCE
+#  GNU's gcc does not like to compile swig-generated code
+#  (at least not with our strict X_CFLAGS), complaining about
+#  "warning: dereferencing type-punned pointer will break strict-aliasing 
rules",
+#  "warning: unused variable '...'",
+#  "warning: '..' defined but not used",
+#  "warning: unused parameter '...'", and/or
+#  'error: "..." is not defined'.
+#  Hence, we use GCC_SWIG_CFLAGS to disable the respective warning
+#  as locally as possbile via "-Wno-strict-aliasing -Wno-unused-variable 
-Wno-unused-function -Wno-unused-parameter -Wno-undef".
+#  Intel's icc does not like to compile swig-generated code
+#  (at least not with our strict X_CFLAGS), complaining about
+#  'error #869: parameter "..." was never referenced',
+#  'error #177: function "..." was declared but never referenced', and/or
+#  'error #310: old-style parameter list (anachronism)'.
+#  Hence, we use ICC_SWIG_CFLAGS to disable the respective warning
+#  as locally as possbile via "-wd869 -wd177 -wd310".
+#  (See also buildtools/conf/MonetDB.m4.)
+CFLAGS = $(GCC_SWIG_CFLAGS) $(ICC_SWIG_CFLAGS) -DCOMPILE_DL_MONETDB=1 
-D_GNU_SOURCE
 
 SUBDIRS = examples 
 


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Monetdb-checkins mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/monetdb-checkins

Reply via email to