Jennie,

just out of "pure curiosity":

had you been able to compile your original version (that failed to compile
with testing on all platforms) prior to checking it in?

Stefan

On Thu, Nov 01, 2007 at 01:27:40PM +0100, Ying Zhang wrote:
> On Thu, Nov 01, 2007 at 12:30:31PM +0100, Fabian Groffen wrote:
> > On 01-11-2007 10:48:18 +0000, Ying Zhang wrote:
> > > Update of /cvsroot/monetdb/pathfinder/src/tools/java
> > > In directory sc8-pr-cvs16.sourceforge.net:/tmp/cvs-serv5671
> > > 
> > > Modified Files:
> > >       Tag: XQuery_0-20
> > >   build.properties 
> > > Log Message:
> > > Corrected value of the "compiler" attribute of <javac>
> > [snip]
> > >  # which Java compiler to use, default: javac
> > > -build_compiler=javac
> > > +build_compiler=javac1.5
> > 
> > While the comment doesn't reflect a valid state here, this isn't too
> > flexible.  Why don't you just drop the whole build_compiler variable you
> > introduced, and use the completely transparent and well supported and
> > usually expected build.compiler variable only once you really want to
> > control what compiler is being used, as I suggested to you earlier?
> 
> Just because I haven't read your previous mail before commit the change.
> Hence, thanks for the suggestion, and I will change it again.
> 
> Jennie

-- 
| Dr. Stefan Manegold | mailto:[EMAIL PROTECTED] |
| CWI,  P.O.Box 94079 | http://www.cwi.nl/~manegold/  |
| 1090 GB Amsterdam   | Tel.: +31 (20) 592-4212       |
| The Netherlands     | Fax : +31 (20) 592-4312       |

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Monetdb-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/monetdb-developers

Reply via email to