Dear all,
I do see the point that we do not necessarily distribute released source
tarballs with "--enable-strict" as default, as this might "unnecessarily"
hinder compilation with compilers and/or environments that "we don't know
yet".
However, nightly testing does explicitly use --enable-strict both both the
development trunk ("Current") and the release branch ("Stable") to ensure
"correctness" of the code.
This leads to the "inconvenient" situation that, during bug fixing, developers
that do not explicitly use "--enable-strict" compile with the default
"--disable-strict" and consequently might miss small (but "nasty") problems
that then cause nightly testing to fail.
To solve this "dilemma", I came up with the idea to make the default setting
"more flexible" and "automatically detect" whether a developer is compiling
from CVS or a user is compiling from source tarball(s). In the former case,
the default is "--enable-strict", it the latter it is "--disable-strict".
Here's my patch:
========
--- buildtools/conf/MonetDB.m4 24 May 2008 17:13:41 -0000 1.75.2.1
+++ buildtools/conf/MonetDB.m4 6 Jun 2008 06:14:32 -0000
@@ -17,7 +17,15 @@
dnl Defaults that differ between development trunk and release branch:
AC_DEFUN([AM_MONETDB_DEFAULTS],
[
-dft_strict=no
+if test -f "$srcdir"/vertoo.data; then
+ dnl Developers compiling from CVS:
+ dnl default is --enable-strict
+ dft_strict=yes
+else
+ dnl Users compiling from source tarball(s):
+ dnl default is --disable-strict
+ dft_strict=no
+fi
dft_assert=no
dft_optimi=yes
dft_warning=no
========
In case there are no (strong) objections, I'd like to check this in later
today.
Open question: shall we only do this on the release branch and keep
"--enable-strict" as default in all cases in the development trunk, or shall
we apply the same strategy o the development trunk, too?
Yours,
Stefan
On Fri, Jun 06, 2008 at 06:45:45AM +0200, Testweb Compilation wrote:
> opt_icol.c:376: warning: enumeration value 'la_dummy' not handled in switch
>
> 374 if (L(p)->kind == la_twig &&
> 375 !PFprop_icol (p->prop,
> L(p)->sem.iter_item.item))
> 376 switch (LL(p)->kind) {
> 377
> 378 case la_docnode:
>
> /home/monet/testing/monet.GNU.32.32.d.2271/pathfinder/compiler/algebra/opt/opt_icol.c:376:
> warning: enumeration value 'la_string_join' not handled in switch
> /home/monet/testing/monet.GNU.32.32.d.2271/pathfinder/compiler/algebra/opt/opt_icol.c:376:
> warning: enumeration value 'la_dummy' not handled in switch
> make[8]: *** [libopt_la-opt_icol.lo] Error 1
>
> http://www.ins.cwi.nl/~monet/permastore/2008-06-06/Stable/make-pathfinder-GNU.32.32.d-Debian4.0.errors.html#l408
>
> CVS committers: [EMAIL PROTECTED] [EMAIL PROTECTED] [EMAIL PROTECTED] [EMAIL
> PROTECTED] [EMAIL PROTECTED] [EMAIL PROTECTED]
>
> An identical error message was detected on the following systems:
> GNU.32.32.d-Debian4.0 GNU.32.32.d-Fedora6 GNU.32.32.d-Fedora8
> GNU.64.32.d-Fedora8 GNU.64.64.d-Fedora8 GNU.64.64.s-Fedora8
>
> --
> At this time you cannot configure Testing mail, sorry
> You are receiving this mail because:
> - you checked in some code on pathfinder (Stable)
> - you are a fixed recipient
>
>
--
| Dr. Stefan Manegold | mailto:[EMAIL PROTECTED] |
| CWI, P.O.Box 94079 | http://www.cwi.nl/~manegold/ |
| 1090 GB Amsterdam | Tel.: +31 (20) 592-4212 |
| The Netherlands | Fax : +31 (20) 592-4312 |
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Monetdb-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/monetdb-developers
