Martin,

just for info:

while chasing other property checking errors, I happened to notice that this
checkin makes tests 

        MonetDB5/src/mal/Tests/tst911.mal
        MonetDB5/src/mal/Tests/tst912.mal

fail with

!MALException:mal.propertyCheck:Object not found

Stefan


On Tue, Aug 18, 2009 at 06:10:37AM +0000, Martin Kersten wrote:
> Update of /cvsroot/monetdb/MonetDB5/src/mal
> In directory 23jxhf1.ch3.sourceforge.com:/tmp/cvs-serv1398
> 
> Modified Files:
>       Tag: Aug2009
>       mal_interpreter.mx 
> Log Message:
> The accidental loss of a BAT was ignored, while it should lead to an
> exception. All other GDKerrors are already converted in a MALexception
> with catchKernelException before the interpreter loop terminates.
> 
> 
> U mal_interpreter.mx
> Index: mal_interpreter.mx
> ===================================================================
> RCS file: /cvsroot/monetdb/MonetDB5/src/mal/mal_interpreter.mx,v
> retrieving revision 1.313.2.2
> retrieving revision 1.313.2.3
> diff -u -d -r1.313.2.2 -r1.313.2.3
> --- mal_interpreter.mx        17 Aug 2009 13:53:47 -0000      1.313.2.2
> +++ mal_interpreter.mx        18 Aug 2009 06:10:35 -0000      1.313.2.3
> @@ -1615,8 +1615,10 @@
>               if( stk->stk[getArg(pci,i)].vtype == TYPE_bat &&
>                               stk->stk[getArg(pci,i)].val.bval ){
>                       b= BATdescriptor(stk->stk[getArg(pci,i)].val.bval);
> -                     if( b == NULL)
> +                     if( b == NULL){
> +                             ret = createException(MAL, "mal.propertyCheck", 
> RUNTIME_OBJECT_MISSING);
>                               continue;
> +                     }
>                       if( b->batStamp <= stamp){
>                               if( GDKdebug & 8)
>                                       @:batpropcheck(b)@
> @@ -1624,9 +1626,6 @@
>                               if( GDKdebug & 2)
>                                       @:batpropcheck(b)@
>                       BBPunfix(b->batCacheid);
> -                     if( cntxt->errbuf && cntxt->errbuf[0]) {
> -                             ret = createException(MAL, "mal.propertyCheck", 
> RUNTIME_OBJECT_MISSING);
> -                     }
>               }
>       }
>  #endif
> 
> 
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
> trial. Simplify your report design, integration and deployment - and focus on 
> what you do best, core application coding. Discover what's new with 
> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> _______________________________________________
> Monetdb-checkins mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/monetdb-checkins

-- 
| Dr. Stefan Manegold | mailto:[email protected] |
| CWI,  P.O.Box 94079 | http://www.cwi.nl/~manegold/  |
| 1090 GB Amsterdam   | Tel.: +31 (20) 592-4212       |
| The Netherlands     | Fax : +31 (20) 592-4312       |

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Monetdb-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/monetdb-developers

Reply via email to