On 2012-02-16 09:16, Sjoerd Mullender wrote:
> On 2012-02-15 20:12, Stefan Manegold wrote:
>> Changeset: fc0d3fad41c2 for MonetDB
>> URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=fc0d3fad41c2
>> Modified Files:
>>      gdk/gdk_calc.c
>> Branch: gdk-calc
>> Log Message:
>>
>> gdk_calc.c, mod_typeswitchloop(): initialize "nils" (hopefully correctly)
> 
> Which sucky compiler was this?  There is no code path where nils was not
> initialized.  (This also means that the value you choose here doesn't
> matter.)

I take my words back.  There was a default case missing.  Adding that
was the correct fix.

>>
>> diffs (12 lines):
>>
>> diff --git a/gdk/gdk_calc.c b/gdk/gdk_calc.c
>> --- a/gdk/gdk_calc.c
>> +++ b/gdk/gdk_calc.c
>> @@ -6157,7 +6157,7 @@ mod_typeswitchloop(const void *lft, int 
>>                 void *dst, int tp, BUN cnt,
>>                 int abort_on_error, const char *func)
>>  {
>> -    BUN nils;
>> +    BUN nils = BUN_NONE;
>>  
>>      switch (ATOMstorage(tp1)) {
>>      case TYPE_bte:
>> _______________________________________________
>> Checkin-list mailing list
>> checkin-l...@monetdb.org
>> http://mail.monetdb.org/mailman/listinfo/checkin-list
> 
> 
> 
> 
> ------------------------------------------------------------------------------
> Virtualization & Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing 
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
> 
> 
> 
> _______________________________________________
> Monetdb-developers mailing list
> Monetdb-developers@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/monetdb-developers


-- 
Sjoerd Mullender

Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Monetdb-developers mailing list
Monetdb-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/monetdb-developers

Reply via email to