This message was forwarded from developers-l...@monetdb.org. The MonetDB
mailing lists have moved to monetdb.org. Please subscribe to
developers-l...@monetdb.org, and unsubscribe from this list.
See: http://mail.monetdb.org/mailman/listinfo/developers-list
Send developers-list mailing list submissions to
developers-l...@monetdb.org
To subscribe or unsubscribe via the World Wide Web, visit
http://mail.monetdb.org/mailman/listinfo/developers-list
or, via email, send a message with subject or body 'help' to
developers-list-requ...@monetdb.org
You can reach the person managing the list at
developers-list-ow...@monetdb.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of developers-list digest..."
Today's Topics:
1. Re: MonetDB: default - fixed a low level bug where empty mapi
result... (Sjoerd Mullender)
2. Re: MonetDB: default - fixed a low level bug where empty mapi
result... (Gijs Molenaar)
----------------------------------------------------------------------
Message: 1
Date: Fri, 14 Dec 2012 14:35:32 +0100
From: Sjoerd Mullender <sjo...@monetdb.org>
To: developers-l...@monetdb.org
Subject: Re: MonetDB: default - fixed a low level bug where empty mapi
result...
Message-ID: <50cb2b24.80...@monetdb.org>
Content-Type: text/plain; charset=UTF-8
On 2012-12-14 12:10, Gijs Molenaar wrote:
> Changeset: 81f191d61822 for MonetDB
> URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=81f191d61822
> Modified Files:
> clients/python2/monetdb/mapi.py
> clients/python3/monetdb/mapi.py
> Branch: default
> Log Message:
>
> fixed a low level bug where empty mapi results where not properly handled
Is this is fix that should have gone to the Oct2012 branch?
Please, make sure you fix bugs in the lowest branch where the bug occurs
and that is still maintained. Currently the still maintained branches
are Oct2012, Feb2013 and default.
>
> diffs (30 lines):
>
> diff --git a/clients/python2/monetdb/mapi.py b/clients/python2/monetdb/mapi.py
> --- a/clients/python2/monetdb/mapi.py
> +++ b/clients/python2/monetdb/mapi.py
> @@ -163,9 +163,9 @@ class Connection(object):
> self.__putblock(operation)
> response = self.__getblock()
> if not len(response):
> - return True
> + return ""
> elif response.startswith(MSG_OK):
> - return response[3:].strip() or True
> + return response[3:].strip() or ""
Isn't this equivalent to:
return response[3:].strip()
> if response == MSG_MORE:
> # tell server it isn't going to get more
> return self.cmd("")
> diff --git a/clients/python3/monetdb/mapi.py b/clients/python3/monetdb/mapi.py
> --- a/clients/python3/monetdb/mapi.py
> +++ b/clients/python3/monetdb/mapi.py
> @@ -163,9 +163,9 @@ class Connection(object):
> self.__putblock(operation)
> response = self.__getblock()
> if not len(response):
> - return True
> + return ""
> elif response.startswith(MSG_OK):
> - return response[3:].strip() or True
> + return response[3:].strip() or ""
> if response == MSG_MORE:
> # tell server it isn't going to get more
> return self.cmd("")
> _______________________________________________
> checkin-list mailing list
> checkin-l...@monetdb.org
> http://mail.monetdb.org/mailman/listinfo/checkin-list
>
--
Sjoerd Mullender
------------------------------
Message: 2
Date: Fri, 14 Dec 2012 15:05:12 +0100
From: Gijs Molenaar <g.j.molen...@uva.nl>
To: "Communication channel for developers of the MonetDB suite."
<developers-l...@monetdb.org>
Subject: Re: MonetDB: default - fixed a low level bug where empty mapi
result...
Message-ID: <50cb3218.3070...@uva.nl>
Content-Type: text/plain; charset="iso-8859-1"
On 12/14/2012 02:35 PM, Sjoerd Mullender wrote:
> On 2012-12-14 12:10, Gijs Molenaar wrote:
>> Changeset: 81f191d61822 for MonetDB
>> URL: http://dev.monetdb.org/hg/MonetDB?cmd=changeset;node=81f191d61822
>> Modified Files:
>> clients/python2/monetdb/mapi.py
>> clients/python3/monetdb/mapi.py
>> Branch: default
>> Log Message:
>>
>> fixed a low level bug where empty mapi results where not properly handled
>
> Is this is fix that should have gone to the Oct2012 branch?
Probably yes.
> Please, make sure you fix bugs in the lowest branch where the bug occurs
> and that is still maintained. Currently the still maintained branches
> are Oct2012, Feb2013 and default.
I just discovered this issue and I didn't had the time anymore
to merge it into the other branches. I'm not able to do merge them anymore
today due to time constrains, sorry.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
URL:
<http://mail.monetdb.org/pipermail/developers-list/attachments/20121214/faa037a0/attachment.sig>
------------------------------
_______________________________________________
developers-list mailing list
developers-l...@monetdb.org
http://mail.monetdb.org/mailman/listinfo/developers-list
End of developers-list Digest, Vol 4, Issue 12
**********************************************
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Monetdb-developers mailing list
Monetdb-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/monetdb-developers
