Update of /cvsroot/monetdb/pathfinder/compiler/mil
In directory sc8-pr-cvs7.sourceforge.net:/tmp/cvs-serv24382/compiler/mil

Modified Files:
      Tag: XQuery_0-16
        milprint_summer.c 
Log Message:
Fix bug [ 1655857 ] XQ: call to builtin function crashes XRPC client

The error handling was improper.  It did not terminate MIL generate,
hence results in a crash.

Test added in

tests/BugTracker/Tests/call2builtin_function_crashes_XRPC_client.SF-1655857




Index: milprint_summer.c
===================================================================
RCS file: /cvsroot/monetdb/pathfinder/compiler/mil/milprint_summer.c,v
retrieving revision 1.318.2.7
retrieving revision 1.318.2.8
diff -u -d -r1.318.2.7 -r1.318.2.8
--- milprint_summer.c   8 Feb 2007 18:15:23 -0000       1.318.2.7
+++ milprint_summer.c   9 Feb 2007 10:33:57 -0000       1.318.2.8
@@ -6224,13 +6224,11 @@
     PFcnode_t *args = RD(xrpc);
 
     if (fun->builtin){
-        milprintf(f,
-                "{ERROR (\"XRPC calls to builtin functions"
-                " are not allowed.\"); }\n");
+        PFoops (OOPS_NOTSUPPORTED,
+                "RPC calls to built-in functions not supported by XRPC.");
     } else if (fun->qname.ns.uri == NULL) {
-        milprintf(f,
-                "{ERROR (\"Functions called via XRPC should defined"
-                " in a module definition.\"); }\n");
+        PFoops (OOPS_NOTSUPPORTED,
+                "RPC calls to in-line functions not supported by XRPC.");
     }
 
     milprintf(f, "{ # begin of XRPC function call\n");


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Monetdb-pf-checkins mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/monetdb-pf-checkins

Reply via email to