Update of /cvsroot/monetdb/sql/src/server
In directory sfp-cvsdas-1.v30.ch3.sourceforge.com:/tmp/cvs-serv30585
Modified Files:
Tag: Nov2009
sql_schema.mx
Log Message:
Removed superfluous NULL check: if impl==NULL, we would have gotten a
crash in the call to mvc_create_type.
Found by Coverity.
Index: sql_schema.mx
===================================================================
RCS file: /cvsroot/monetdb/sql/src/server/sql_schema.mx,v
retrieving revision 1.181.2.1
retrieving revision 1.181.2.2
diff -u -d -r1.181.2.1 -r1.181.2.2
--- sql_schema.mx 11 Nov 2009 19:41:59 -0000 1.181.2.1
+++ sql_schema.mx 2 Dec 2009 12:49:59 -0000 1.181.2.2
@@ -479,9 +479,7 @@
char *tname = qname_table(qname);
if (!mvc_create_type(sql, sql->session->schema, tname, 0, 0, 0, impl)) {
- if (impl)
- return sql_error(sql, 02, "CREATE TYPE: unknown
external type '%s'", impl);
- return NULL;
+ return sql_error(sql, 02, "CREATE TYPE: unknown external type
'%s'", impl);
}
return stmt_none();
}
------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience,
a free event focused on virtualization and cloud computing.
Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev
_______________________________________________
Monetdb-sql-checkins mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/monetdb-sql-checkins
