Update of /cvsroot/monetdb/sql/src/server
In directory sfp-cvsdas-1.v30.ch3.sourceforge.com:/tmp/cvs-serv4304
Modified Files:
Tag: Nov2009
rel_bin.mx
Log Message:
Move check of update to outside if. If the if wasn't taken, we would
get a crash.
Niels, how is this supposed to work?
Found by Coverity.
Index: rel_bin.mx
===================================================================
RCS file: /cvsroot/monetdb/sql/src/server/rel_bin.mx,v
retrieving revision 1.93.2.6
retrieving revision 1.93.2.7
diff -u -d -r1.93.2.6 -r1.93.2.7
--- rel_bin.mx 7 Jan 2010 15:18:50 -0000 1.93.2.6
+++ rel_bin.mx 11 Jan 2010 10:16:01 -0000 1.93.2.7
@@ -3143,9 +3143,9 @@
if (rel->r) { /* first construct the update relation */
update = subrel_bin(sql, rel->r, refs);
- if (!update)
- return NULL;
}
+ if (!update)
+ return NULL;
updates = table_update_array(t, &len);
tid = update->op1.lval->h->data;
for (n = update->op1.lval->h->next, m = rel->exps->h;
------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________
Monetdb-sql-checkins mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/monetdb-sql-checkins
