Update of /cvsroot/monetdb/sql/src/backends/monet5
In directory sfp-cvsdas-1.v30.ch3.sourceforge.com:/tmp/cvs-serv16027
Modified Files:
Tag: Feb2010
sql_scenario.mx
Log Message:
If we first blindly dereference a value, we don't have to check later
whether that value can be dereferenced.
Found by Coverity.
Niels, please check correctness: is m->session really != NULL.
Index: sql_scenario.mx
===================================================================
RCS file: /cvsroot/monetdb/sql/src/backends/monet5/sql_scenario.mx,v
retrieving revision 1.372.2.1
retrieving revision 1.372.2.2
diff -u -d -r1.372.2.1 -r1.372.2.2
--- sql_scenario.mx 26 Jan 2010 21:31:11 -0000 1.372.2.1
+++ sql_scenario.mx 10 Feb 2010 15:38:26 -0000 1.372.2.2
@@ -458,6 +458,7 @@
if ( m == NULL)
throw(SQL, "SQLexitClient", "MVC catalogue not
available");
+ assert(m->session);
if (m->session->auto_commit && m->session->active) {
if (mvc_status(m) >= 0 && mvc_commit(m, 0, NULL) < 0)
(void) handle_error(m, c->fdout, 0);
@@ -468,7 +469,7 @@
res_tables_destroy(m->results);
m->results= NULL;
- if (m->session && m->session->tr)
+ if (m->session->tr)
reset_functions(m->session->tr);
}
c->state[MAL_SCENARIO_READER] = NULL;
------------------------------------------------------------------------------
SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
http://p.sf.net/sfu/solaris-dev2dev
_______________________________________________
Monetdb-sql-checkins mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/monetdb-sql-checkins
