All sounds good. Fastthread and cgi_multipart are going away so there is no sense worrying about them. In 1.2 they get required if they are installed, but they are not gem dependencies for any platform.
Evan On Mon, Mar 31, 2008 at 12:25 AM, Luis Lavena <[EMAIL PROTECTED]> wrote: > On Mon, Mar 31, 2008 at 1:04 AM, Evan Weaver <[EMAIL PROTECTED]> wrote: > > Wow, that is bizarre. > > > > The platform checks are fine. Do they belong in Mongrel, or do they > > belong in the build chain? > > > > Specific platform usage inside mongrel: > > - To writer or not the pid file: > > http://mongrel.rubyforge.org/browser/trunk/lib/mongrel/configurator.rb#L83 > > (which is pointless, it should generate the pid file on every > platform, even Windows). > > - Allow or not daemonize: > > http://mongrel.rubyforge.org/browser/trunk/lib/mongrel/configurator.rb#L189 > > Which is fair, it should remain there > > - Setup signals: > > http://mongrel.rubyforge.org/browser/trunk/lib/mongrel/configurator.rb#L364 > > Which is also good. > > Other places: > > http://mongrel.rubyforge.org/browser/trunk/bin/mongrel_rails#L139 > > the usage of restart on Windows, seems logical, since there are no > signals to handle it. > > Oh, a good catch: > > http://mongrel.rubyforge.org/browser/trunk/bin/mongrel_rails#L85 > > Mongrel should validate pre-existing pids always, not only in > daemonize mode. Thoughts? > > To use or not fastthread and cgi eof fix. > > http://mongrel.rubyforge.org/browser/trunk/lib/mongrel.rb#L13 > > Of course, a few more check on the new Logger (buffered logger) and > cgi_multipart eof subproject. Fastthread, GemPlugin and even > mongrel_service (yeah, I plain suck at planing on the long run). > > -- > > > Luis Lavena > Multimedia systems > - > Human beings, who are almost unique in having the ability to learn from > the experience of others, are also remarkable for their apparent > disinclination to do so. > Douglas Adams > _______________________________________________ > Mongrel-development mailing list > [email protected] > http://rubyforge.org/mailman/listinfo/mongrel-development > -- Evan Weaver Cloudburst, LLC _______________________________________________ Mongrel-development mailing list [email protected] http://rubyforge.org/mailman/listinfo/mongrel-development
