Jos Backus <[EMAIL PROTECTED]> wrote: > On Wed, Aug 20, 2008 at 01:27:37AM -0700, Eric Wong wrote: > > Jos Backus <[EMAIL PROTECTED]> wrote: > > > On Mon, Aug 18, 2008 at 02:59:21PM -0700, Eric Wong wrote: > > > > This probably works: > > > > > > Looks reasonable to me. Thanks, Eric. Can somebody commit, please? > > > > I've just committed it, r1036 to trunk. Thanks for the report! > > Thanks Eric. The patch is probably incomplete, as I just noticed a problem: > > /usr/lib/ruby/gems/1.8/gems/mongrel-1.1.5/bin/../lib/mongrel.rb:94:in > `initialize': uninitialized constant Mongrel::HttpServer::Fcntl (NameError) > > That code doesn't have the defined? test. But even if it did, it wouldn't work > as `fcntl' hadn't been require'd so the Fcntl::FD_CLOEXEC constant couldn't be > available until it was (if it was available). > > So the right thing to do is to also apply this patch which explicitly > require's `fcntl':
Applied, thanks! -- Eric Wong _______________________________________________ Mongrel-development mailing list [email protected] http://rubyforge.org/mailman/listinfo/mongrel-development
