El Lunes, 28 de Diciembre de 2009, Eric Wong escribió:
> Iñaki Baz Castillo <[email protected]> wrote:
> > El Lunes, 28 de Diciembre de 2009, Eric Wong escribió:
> > > > As a suggestion, could the grandparent rescue such exception and
> > > > display some kind of error message?:
> > > >
> > > > "The master couldn't be started. Inspect the log error or run in
> > > > foreground"
> > >
> > > Thanks, pushed out to the ready_pipe branch of unicorn.git
> >
> > Hi, I attach a minor patch to make the error more verbose when Unicorn
> > cannot listen in a socket.
>
> Hi, it seems like you didn't attach the patch.
Ops, usually my mail client (Kmail) warns me when I write tha word "attach"
but attach nothing... not sure why it didn't it this time.
> Attaching patches is
> strongly discouraged, though, inline patches are far easier to
> review/edit/apply.
Ok, here it's (note that it's done over 'ready_pipe' branch):
--- unicorn.rb.orig 2009-12-28 21:02:47.000000000 +0100
+++ unicorn.rb 2009-12-28 21:11:12.000000000 +0100
@@ -307,6 +307,9 @@
"(#{tries < 0 ? 'infinite' : tries} tries left)"
sleep(delay)
retry
+ rescue => err
+ logger.fatal "error adding listener addr=#{address}"
+ raise err
end
end
--
Iñaki Baz Castillo <[email protected]>
_______________________________________________
Unicorn mailing list - [email protected]
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying
