Tom Burns <tom.bu...@jadedpixel.com> wrote: > + if set[:check_client_connection] > + set[:listeners].each do |address| > + if set[:listener_opts][address][:tcp_nopush] == true > + raise ArgumentError, > + "check_client_connection is incompatible with tcp_nopush:true" > + end
Btw, were you using: 1) TCP over loopback (bound to 0.0.0.0, client comes from 127.0.0.1) 2) TCP over a LAN (separate client/server hosts) 3) Unix domain socket I wonder if we can drop the below hunk for checking :tcp_nodelay, and document that check_client_connection requires the client to either be from a Unix domain socket or TCP loopback to work. > + if set[:listener_opts][address][:tcp_nodelay] == true > + raise ArgumentError, > + "check_client_connection is incompatible with tcp_nodelay:true" > + end I couldn't get 2) to work with either value of tcp_nodelay. My small LAN at home only has ~0.100ms latency. Happily, with TCP over loopback (on Linux 3.6), either value of tcp_nodelay works, so the tcp_nodelay check seems unnecessary after all. _______________________________________________ Unicorn mailing list - mongrel-unicorn@rubyforge.org http://rubyforge.org/mailman/listinfo/mongrel-unicorn Do not quote signatures (like this one) or top post when replying
