Hi, > Thanks. File a ticket please if you think it's definitely bug: > > http://mongrel.rubyforge.org/report/1
sorry to be a bother, but: I can't decide if it is really a bug, as my knowledge regarding mongrel innards is next to non-existant. The implications of 'done' being set or not set in certain corner cases is not something which I can easily be sure of. >> I found this while digging inside mongrel to provide IO streaming >> for mongrel (and thus for Rack and Ramaze): >> >> * In socket_error a local variable done is set, which has no effect. >> * done=() always sets to true, where it (for completeness sake) should >> honor the passed value. >> * If done=() is never reverted, it might be more beneficial to replace >> done=(val) just by a done!() and call that in socket_error() instead. As I see it, done=() is never called at the moment (I might be wrong), and Mongrel still works. Making done=() work correctly might have other implications. Right now it might process additional handlers (mongrel.rb: 160) which it might not do after the fix. Jo -- Using Opera's revolutionary e-mail client: http://www.opera.com/mail/ _______________________________________________ Mongrel-users mailing list Mongrel-users@rubyforge.org http://rubyforge.org/mailman/listinfo/mongrel-users
