Hmm should have checked the patch better before I commited to CVS I see :)

On 24. jul. 2007, at 00.01, Martin Pala wrote:

CVSROOT:        /sources/monit
Module name:    monit
Changes by:     Martin Pala <martinp>     07/07/23 22:01:32

Modified files:
        process        : sysdep_DARWIN.c

Log message:
        removed the retry loop add recently - there are has several problems:
        
1.) in the case that sysctl would return > 0, the loop is endless and monit will hung
        
2.) in the case that sysctl returns < 0, monit will hung for up to 1000s
        
Both cases are undesirable, the monitoring should continue. In the case of transient error, it is better to return the error immediatelly, continue validation and try next cycle. The state where sysctl is failing (even due to high load) is bad and user should be notified because other applications will be affected by it as well
        and may behave wrongly.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/monit/process/sysdep_DARWIN.c? cvsroot=monit&r1=1.32&r2=1.33


_______________________________________________
monit-dev mailing list
[email protected]
http://lists.nongnu.org/mailman/listinfo/monit-dev

Reply via email to