Hi Mahesh, first of all thanks for take some time to work on this!
On Thu, Mar 22, 2012 at 1:31 PM, Mahesh Gondi <[email protected]> wrote: > Hi, > > I've pushed some commits to my github repo at > [https://github.com/maheshgondi/monkey] . This version, resulted in > sqlite(added to monkey) being only used in case of platform being set to > android, else it uses the installed sqlite library. Great!, if these changes makes the android toolchain works we need to deal with this issue: - Monkey aims to be lightweight, so as part of its tarball distribution we cannot distribute the full sqlite3 source code inside it, but we need it for Android. I think that this concern could be addressed by a different way to distribute Duda Packages.. this requires some discussion no rush in a decision at this point > > This repo other than my commits contains changes upto "Duda: add new > 'params' object to handle parameters" commits at git.monkey-project.com / > > Following are the changes made by : > > 1. Fixed duda/package/sqlite/Makefile.in by removing the linking to > libsqlite through -lsqlite3.This wasn't need for running the monkey with the > nomal toolchain[GNU]. > > It took me some good time to realize that linking to libsqlite wasn't > required at all while trying to do something like conditional > linking(similar to con.d compiling). > > > 2. Made changes in the function create_info in the configure file. Changes > set macro for PF_GENERIC(1), PF_ANDROID(2), PLATFORM(whichever platform is > being targetted). create_info writes mk_info.h, which is later used for > conditional compilation whether to use lib-sqite or the local sqlite. > > mk_info.h now contains the info about the target it is being compiled for, > so that plugins may take a different course of action when needed > > 3. In plugins/duda/packages/sqlite, two files are effected. sqlite.c now > includes doesn't include sqlite3.h(provided by libsqlite). and sqlite.h now > contains the conditionally compiled code based values macro[PLATFORM which > is either set to PF_GENERIC or PF_ANDROID] set in mk_info.h. > PF_GENERIC ===>> 1 > PF_ANDROID ===>> 2 > I would suggest to rename the flags to something like: MK_PLATFORM_GENERIC MK_PLATFORM_ANDROID > 4. added sqlite code containing 4 files into the directory sqlite_main > inside plugins/duda/packages/sqlite. > > > 5. All the necessary changes have been made to required make files. > > > 1,2,3 are in the most recent commit : > https://github.com/maheshgondi/monkey/commit/c168488e1057ad155b5459e1eed9ce0413f00414 > > 4,5 are in the commit > https://github.com/maheshgondi/monkey/commit/cfbc2102b02ffc512a89a01c682b6253bfe871d1 > > Between these two commits, repo includes updates at git.monkey-project.com . > > for future work : Option can be easily give during compilation, to the user > to use sqlite provided with monkey instead of existing installed libsqlite. > > Please, review the above commits and let me know if any changes further be > made. It's fun get to know monkey more & more daily. :) > So far this is a great job!, as Duda is still under heavy development we can still looking for solutions to the package requirements distribution, if Android have too many special issues we should think into branch in a new monkey-android... cheers! > Regards, > mahesh gondi > _______________________________________________ > Monkey mailing list > [email protected] > http://lists.monkey-project.com/listinfo/monkey > -- Eduardo Silva http://edsiper.linuxchile.cl http://www.monkey-project.com _______________________________________________ Monkey mailing list [email protected] http://lists.monkey-project.com/listinfo/monkey
