Thanks for the reviews, will do the necessary changes and send the patch. On Sun, Mar 25, 2012 at 11:58 PM, Eduardo Silva <[email protected]> wrote:
> Hi, > > thanks for the patch, just a minor changes and we are ok: > > 1) rename "duda_set_invoked_method(struct duda_request *dr)" to > duda_request_set_method(...) > > 2) rename dr->_invoked_method to dr->_method > > also: > > 3) generate patches with: git format-patch -1 , we need to get each > patch as an attachment, if required use the attachment format of git > > 4) In the GIT commit, do a good description about what this patch is doing > > 5) When modifying the examples, do a separate commit > > cheers > > On Sun, Mar 25, 2012 at 7:18 AM, Sourabh Chandak <[email protected]> > wrote: > > Hi, > > > > txt version of the last patch attached. > > > > > > On Sun, Mar 25, 2012 at 11:31 AM, Sourabh Chandak <[email protected] > > > > wrote: > >> > >> Hi, > >> > >> Have made the modifications suggested by Eduardo, now there exists a > >> variable of the type duda_method in duda_request which is used to > compare > >> the parameters count in the URL with the allowed count. > >> > >> On Fri, Mar 23, 2012 at 3:13 PM, Sourabh Chandak <[email protected] > > > >> wrote: > >>> > >>> Hi, > >>> > >>> The webservice URL supported specifying more parameters than > permissible > >>> for a particular method. The restriction was laid on the number of > >>> parameters globally(i.e it can't be more than MAP_WS_MAX_PARAMS). Have > fixed > >>> that, now the callback method will display results only when correct > number > >>> of parameters are specified. > >>> > >>> In the function duda_service_run in duda.c the outer loop iterated for > >>> all the interfaces even though the corresponding callback method was > found. > >>> Have fixed that, possibly it will decrease time when a large number of > >>> interfaces are present in a webservice. > >>> > >>> Further I am working on changing the way parameters are retrieved from > >>> integer to char *. > >>> > >>> Please review the attached patch and send your comments. > >>> > >>> Regards, > >>> > >>> -- > >>> Sourabh Chandak > >>> > >>> > >>> > >> > >> > >> > >> -- > >> Sourabh Chandak > >> > >> > >> > > > > > > > > -- > > Sourabh Chandak > > > > > > > > > > -- > Eduardo Silva > http://edsiper.linuxchile.cl > http://www.monkey-project.com > -- Sourabh Chandak
_______________________________________________ Monkey mailing list [email protected] http://lists.monkey-project.com/listinfo/monkey
