- Lauri
>From 3fbdfee80160b38c2b8660edcca081bd52d7b502 Mon Sep 17 00:00:00 2001 From: Lauri Kasanen <[email protected]> Date: Thu, 3 May 2012 15:19:00 +0300 Subject: [PATCH 2/6] socket: Fix possible overflow
mk_socket_ip_str passed the wrong size to inet_ntop. Signed-off-by: Lauri Kasanen <[email protected]> --- src/mk_socket.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mk_socket.c b/src/mk_socket.c index 33815b8..bbd3e94 100644 --- a/src/mk_socket.c +++ b/src/mk_socket.c @@ -198,7 +198,7 @@ int mk_socket_ip_str(int socket_fd, char **buf, int size, unsigned long *len) if(addr.sa_family == AF_INET) { if((inet_ntop(addr.sa_family, &((struct sockaddr_in *)&addr)->sin_addr, - *buf, INET_ADDRSTRLEN)) == NULL) { + *buf, size)) == NULL) { MK_TRACE("Can't get the IP text form"); return -1; } @@ -206,7 +206,7 @@ int mk_socket_ip_str(int socket_fd, char **buf, int size, unsigned long *len) if(addr.sa_family == AF_INET6) { if((inet_ntop(addr.sa_family, &((struct sockaddr_in6 *)&addr)->sin6_addr, - *buf, INET6_ADDRSTRLEN)) == NULL) { + *buf, size)) == NULL) { MK_TRACE("Can't get the IP text form"); return -1; } -- 1.7.2.1
_______________________________________________ Monkey mailing list [email protected] http://lists.monkey-project.com/listinfo/monkey
