Hi Fixes a Clang warning. If getpwnam returns NULL, accessing usr->something would segfault.
- Lauri
>From d0730e5e764c3bac851fb7573ac927975706600d Mon Sep 17 00:00:00 2001 From: Lauri Kasanen <[email protected]> Date: Wed, 23 May 2012 17:21:43 +0300 Subject: [PATCH 05/13] user: Fix possible crash Fixes a Clang warning. If getpwnam returns NULL, accessing usr->something would segfault. Signed-off-by: Lauri Kasanen <[email protected]> --- src/mk_user.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/mk_user.c b/src/mk_user.c index e41c7f5..3ba3cc6 100644 --- a/src/mk_user.c +++ b/src/mk_user.c @@ -118,6 +118,7 @@ int mk_user_set_uidgid() /* Check if user exists */ if ((usr = getpwnam(config->user)) == NULL) { mk_err("Invalid user '%s'", config->user); + goto out; } if (initgroups(config->user, usr->pw_gid) != 0) { @@ -136,6 +137,7 @@ int mk_user_set_uidgid() config->is_seteuid = MK_TRUE; } + out: EUID = geteuid(); EGID = getegid(); -- 1.7.2.1
_______________________________________________ Monkey mailing list [email protected] http://lists.monkey-project.com/listinfo/monkey
