applied, thanks! On Wed, Jun 13, 2012 at 3:27 AM, Lauri Kasanen <[email protected]> wrote: > On Tue, 12 Jun 2012 19:32:16 -0600 > Eduardo Silva <[email protected]> wrote: > >> why it *must* be global if is just used by the plugins ? (or the >> library require that ?) > > Every other part of monkey expects it to be the global one. See > mk_plugin_read_config: "ret = p->init(&api, plugin_confdir);" > or mk_plugin_exit_all: "mk_mem_free(api);". > > These both operate on the global api, which would not be initialized if > mk_plugin_init used a local symbol for api. > > ie, without this patch, these parts are buggy and try to use a NULL pointer. > I have no idea how the plugins even worked before this, maybe some linker > magic saved them when they tried to access api->something. > > - Lauri
-- Eduardo Silva http://edsiper.linuxchile.cl http://www.monkey-project.com _______________________________________________ Monkey mailing list [email protected] http://lists.monkey-project.com/listinfo/monkey
