On Sat, 6 Apr 2013 10:42:38 -0600
Eduardo Silva <[email protected]> wrote:

> hI,
> 
> On Sat, Apr 6, 2013 at 2:19 AM, Lauri Kasanen <[email protected]> wrote:
> > The dirlisting plugin still has the corruption in large directories bug. I
> > would advise not releasing 1.2 until it has been fixed.
> >
> >
> thanks, would you please state the specific problem ?, i remember you
> mentioned something before but i cannot find the details,

This one: 
http://lists.monkey-project.com/pipermail/monkey/2012-December/001707.html

dirlisting: Fix filename corruption

> man readdir: "The  data returned by readdir() may be overwritten by  
> subsequent calls to
> readdir() for the same directory stream."
>
> Before this, the plugin was saving a pointer to dirent->d_name, which got 
> corrupted in any
> big directory.

My patch saved it in a copy (strdup), and you advised to change to a static 
buffer instead. I haven't yet had time and need to update the patch for a 
static buffer.

- Lauri
_______________________________________________
Monkey mailing list
[email protected]
http://lists.monkey-project.com/listinfo/monkey

Reply via email to