Ok, here's a new patch with only the Lib part.

Do it exist a generic destructor function for freeing mk_list's or
do one need to create a custom function to free up config->plugins?

Regards,
Bjorn

On Sat, 6 Apr 2013, Eduardo Silva wrote:

the config->plugins is wrong, because config->plugins is a mk_list, that
links "struct plugin" nodes.

Please resubmit only for the Lib part.

regards,


On Sat, Apr 6, 2013 at 1:18 PM, Lauri Kasanen <[email protected]> wrote:

On Sat, 6 Apr 2013 12:34:38 -0600
Eduardo Silva <[email protected]> wrote:

cc: Lauri
On Sat, Apr 6, 2013 at 12:24 PM, Bjorn Lindgren <[email protected]> wrote:

Hi Eduardo,

I'm submitting a patch for two minor memory leaks I discovered in the
mk_lib.

The part in mk_lib looks good. For the mk_config part, I'm not sure if
it's correct to free a mk_list with string_split_free.

- Lauri




--
Eduardo Silva
http://edsiper.linuxchile.cl
http://www.monkey-project.com
From 0e5b543ed3cb9317d98497058d073bede09b031a Mon Sep 17 00:00:00 2001
From: Bjorn Lindgren <[email protected]>
Date: Mon, 8 Apr 2013 09:31:30 +0200
Subject: [PATCH] Lib: fix minor memory leak


Signed-off-by: Bjorn Lindgren <[email protected]>
---
 src/mk_lib.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/src/mk_lib.c b/src/mk_lib.c
index c39bdb1..8a7afe2 100644
--- a/src/mk_lib.c
+++ b/src/mk_lib.c
@@ -496,6 +496,7 @@ int mklib_stop(mklib_ctx ctx)
     free(config);
 #endif
 
+    free(ctx->workers);
     free(ctx);
 
     return MKLIB_TRUE;
-- 
1.7.10.4

_______________________________________________
Monkey mailing list
[email protected]
http://lists.monkey-project.com/listinfo/monkey

Reply via email to