Here's the problem: if we send out less than total bytes and the first i + 1 buffer entries (0 to i) of body buffer add up to exactly *bytes_sent* bytes, we should reset the first i + 1 entries' length to 0 so that we will not process them on the next call. However in the current source code *reset_to *is always assign to 1, which will always just reset the first two entries' length to 0. Thus on the next call, only the first two entries' will not be processed again.
Best Regards, swpd On Tue, May 7, 2013 at 7:12 AM, Eduardo Silva <[email protected]> wrote: > Patches 0002 and 0003 applied. > > About 0001, please explain the problem found/. > > > On Wed, May 1, 2013 at 8:58 AM, Zeying Xie <[email protected]> wrote: > >> Sorry that I forgot to append the patches :P >> >> Here they are. >> >> Regards, >> swpd >> >> >> On Wed, May 1, 2013 at 11:27 AM, Eduardo Silva <[email protected]> wrote: >> >>> cool, and the patches ? >>> >>> >>> On Tue, Apr 30, 2013 at 9:25 PM, Zeying Xie <[email protected]> wrote: >>> >>>> Hi Eduardo, >>>> >>>> Here are some minor patches. >>>> [1/3] Body Buffer: Fix reset count >>>> When the first i + 1 buffer entry(0 to i) add up to be exacly >>>> *bytes_sent* bytes, we should reset the buffer entry from 0 to i. >>>> The current code just assign the reset count to *1*, which >>>> should be *i*. >>>> [2/3] Debug: change to include system header >>>> Just change header like #include "stdio.h" to #include >>>> <stdio.h> >>>> [3/3] Global: change to include system header >>>> same as [2/3] >>>> >>>> Best Regards, >>>> swpd >>>> >>> >>> >>> >>> -- >>> Eduardo Silva >>> http://edsiper.linuxchile.cl >>> http://www.monkey-project.com >>> >> >> >> > > > -- > Eduardo Silva > http://edsiper.linuxchile.cl > http://www.monkey-project.com >
_______________________________________________ Monkey mailing list [email protected] http://lists.monkey-project.com/listinfo/monkey
