Please do not reply to this email- if you want to comment on the bug, go to the URL shown below and enter your comments there.
Changed by [EMAIL PROTECTED] http://bugzilla.ximian.com/show_bug.cgi?id=78525 --- shadow/78525 2006-06-14 09:38:11.000000000 -0400 +++ shadow/78525.tmp.7801 2006-06-14 10:47:40.000000000 -0400 @@ -10,13 +10,12 @@ Component: Windows.Forms AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] QAContact: [EMAIL PROTECTED] TargetMilestone: --- URL: -Cc: Summary: [PATCH] ToolBar does not reflect current selection or the first item when it got focus. This is a copy of item 3 of bug #78446. ToolBar does not reflect current selection or the first item (recently used files) when it got focus. Run FileOpenDialog for example. @@ -26,6 +25,29 @@ proposed fix ------- Additional Comments From [EMAIL PROTECTED] 2006-06-14 09:38 ------- The patch looks ok except for the override of IsInputKey. I don't believe we are allowing additional overrides beyond what MS has. + +------- Additional Comments From [EMAIL PROTECTED] 2006-06-14 10:47 ------- +Peter, would this be fine to change IsInputKey() like below and +override this IsInputKeyInternal() only in ToolBar? If there is other +ways to handle cursor keys *before* IsInputKey(), +PreProcessKeyMessage() etc. I might have better go such a way. + + +Index: System.Windows.Forms/Control.cs +=================================================================== +--- System.Windows.Forms/Control.cs (revision 61693) ++++ System.Windows.Forms/Control.cs (working copy) +@@ -3287,6 +3287,10 @@ + + protected virtual bool IsInputKey (Keys keyData) { + // Doc says this one calls IsInputChar; not sure what to do with that ++ return IsInputKeyInternal (keyData); ++ } ++ ++ internal virtual bool IsInputKeyInternal (Keys keyData) { + return false; + } + _______________________________________________ mono-bugs maillist - [email protected] http://lists.ximian.com/mailman/listinfo/mono-bugs
