Please do not reply to this email- if you want to comment on the bug, go to the URL shown below and enter your comments there.
Changed by [EMAIL PROTECTED] http://bugzilla.ximian.com/show_bug.cgi?id=78594 --- shadow/78594 2006-06-06 20:57:32.000000000 -0400 +++ shadow/78594.tmp.1176 2006-07-03 06:50:58.000000000 -0400 @@ -27,6 +27,20 @@ ------- Additional Comments From [EMAIL PROTECTED] 2006-06-06 20:55 ------- Created an attachment (id=17150) soap.diff + +------- Additional Comments From [EMAIL PROTECTED] 2006-07-03 06:50 ------- +I support the approval of this code. + +Some minor comments: +I think you should import System.Runtime.InteropServices rather than +using fully qualified name in attributes. There are some new empty +lines at the end of method body that probably shouldn't be there. +And I don't think that the code for profile 1.x should be ever +uncommented because this would break serialization compatibility +with MS.NET so it probably should be removed. + +I can't criticize the code itself because it seems to be correct and +the test cases are comprehensive.:) _______________________________________________ mono-bugs maillist - [email protected] http://lists.ximian.com/mailman/listinfo/mono-bugs
