Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

Changed by [EMAIL PROTECTED]

http://bugzilla.ximian.com/show_bug.cgi?id=81467

--- shadow/81467        2007-05-07 19:22:51.000000000 -0400
+++ shadow/81467.tmp.10458      2007-05-07 19:55:41.000000000 -0400
@@ -1,13 +1,13 @@
 Bug#: 81467
 Product: Mono: Class Libraries
 Version: 1.2
 OS: unknown
 OS Details: 
-Status: RESOLVED   
-Resolution: FIXED
+Status: REOPENED   
+Resolution: 
 Severity: Unknown
 Priority: Major
 Component: CORLIB
 AssignedTo: [EMAIL PROTECTED]                            
 ReportedBy: [EMAIL PROTECTED]               
 QAContact: [EMAIL PROTECTED]
@@ -358,6 +358,43 @@
 
     Thanks for pointing this one out.
 
     I applied a patch that would fall back to the old encoding if the
 first one fails.   But it seems like we are going to need to come up
 with a policy on how to deal with these sort of changes.
+
+------- Additional Comments From [EMAIL PROTECTED]  2007-05-07 19:55 -------
+That's not enough. See the diff between r71806 and r71807:
+
+Index: WebHeaderCollection.cs
+===================================================================
+--- WebHeaderCollection.cs     (revision 71806)
++++ WebHeaderCollection.cs     (revision 71807)
+@@ -112,11 +112,10 @@
+               protected WebHeaderCollection (SerializationInfo 
serializationInfo, 
+                                              StreamingContext 
streamingContext)
+               {
+-                      // TODO: test for compatibility with ms.net
+-                      int count = serializationInfo.GetInt32("count");
++                      int count = serializationInfo.GetInt32("Count");
+                       for (int i = 0; i < count; i++) 
+-                              this.Add (serializationInfo.GetString ("k" + i),
+-                                        serializationInfo.GetString ("v" + 
i));
++                              this.Add (serializationInfo.GetString 
(i.ToString ()),
++                                      serializationInfo.GetString ((count + 
i).ToString ()));
+               }
+               
+               internal WebHeaderCollection (bool internallyCreated)
+@@ -279,10 +278,10 @@
+                                                 StreamingContext 
streamingContext)
+               {
+                       int count = base.Count;
+-                      serializationInfo.AddValue ("count", count);
++                      serializationInfo.AddValue ("Count", count);
+                       for (int i = 0; i < count; i++) {
+-                              serializationInfo.AddValue ("k" + i, GetKey 
(i));
+-                              serializationInfo.AddValue ("v" + i, Get (i));
++                              serializationInfo.AddValue (i.ToString (), 
GetKey (i));
++                              serializationInfo.AddValue ((count + 
i).ToString (), Get (i));
+                       }
+               }
+
_______________________________________________
mono-bugs maillist  -  [email protected]
http://lists.ximian.com/mailman/listinfo/mono-bugs

Reply via email to