https://bugzilla.novell.com/show_bug.cgi?id=356657
Summary: [PATCH] CodeGenerator: Replace ugly if-else chains by
visitor pattern
Product: Mono: Class Libraries
Version: SVN
Platform: Other
OS/Version: Other
Status: NEW
Severity: Enhancement
Priority: P5 - None
Component: System
AssignedTo: [email protected]
ReportedBy: [EMAIL PROTECTED]
QAContact: [email protected]
Found By: ---
Created an attachment (id=191985)
--> (https://bugzilla.novell.com/attachment.cgi?id=191985)
proposed patch
I've posted this patch to the mailing list multiple times and got no echo
whatsoever. Maybe a bug report is the way to go...
Attached you'll find patches for CodeGenerator.cs and quite a few
System.CodeDom classes. They implement the Visitor pattern* for the
CodeGenerator (traverser) and the classes in System.CodeDom (nodes to be
visited). The result is much nicer and faster code.
*) Thanks again to Robert Jordan, for sketching out how to apply the
Visitor pattern to the CodeGenerator/CodeDom classes!
The patch is a bit long only because it contains a lot of boiler plate code.
ChangeLog entries are included, all unit tests pass.
Please review.
--
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
_______________________________________________
mono-bugs maillist - [email protected]
http://lists.ximian.com/mailman/listinfo/mono-bugs
