https://bugzilla.novell.com/show_bug.cgi?id=324134
User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=324134#c8 Geoff Norton <[EMAIL PROTECTED]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[EMAIL PROTECTED] --- Comment #8 from Geoff Norton <[EMAIL PROTECTED]> 2008-05-10 14:38:58 MST --- general: - please dont include whitespace changes - please dont include new comments like //CHECKME without an explanation - please try to keep codepaths between sizes similar (ie; dont fix the warning on juts 1 side) - please dont introduce a define in the middle of a function and undefine it later, put it int he header eglib: - why is the darwin special case needed? eglib compiles on 32-bit ppc darwin here, whats different with your host? - this should be in a seperate patch as well mono/mini/exceptions-ppc.c: - why are you backing up extra registers when in 64-bit mode and not 32-bit mode? what is the abi reference? mono/mini/tramp-ppc.c: - why the change to put the lmf in r1 instead of ppc_sp? Unfortunately I have to go so I'll have to review the mini-ppc.(h|c) portions later. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ mono-bugs maillist - [email protected] http://lists.ximian.com/mailman/listinfo/mono-bugs
