https://bugzilla.novell.com/show_bug.cgi?id=396076
User [EMAIL PROTECTED] added comment https://bugzilla.novell.com/show_bug.cgi?id=396076#c8 Ivan Zlatev <[EMAIL PROTECTED]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #8 from Ivan Zlatev <[EMAIL PROTECTED]> 2008-06-19 19:15:58 MDT --- I have applied your patch in r106273 with the modifications as follows (list written down while doing them, so probably not great): 1. Coding Style - space before ( 2. Coding Style - Properties { on same line 3. Coding Style - field naming - no m_ prefixes, etc 4. Coding Style - align parameters list in method signatures to the ones on the previous line. 5. Coding Style - no {} for single line if-else 6. Exception -> NotimplementedException 7. ArgumentNullReferenceException parameter name -> match the string to the param name 8. Removed the commented out CWLs 9. Do not compare exception's message and other details. This might break running the tests on non-english locale as Atsushi Eno pointed out on the mono-devel mailing list recently. Just fail if exception doesn't get thrown instead. 10. ConvertTo_InstanceDescriptor - dropped helper method and used only AreEqual (it will compare all properties of the Padding as it ends up calling Padding.Equals anyway) for the sake of simplicity 11. No need to "internal" helper methods 12. Drop some helper methods here and there and simplify here and there. Tests should be simple and self contained units. Code duplication in tests is fine imho. Mono Project's code guidelines can be found here - http://mono-project.com/Coding_Guidelines -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ mono-bugs maillist - [email protected] http://lists.ximian.com/mailman/listinfo/mono-bugs
