http://bugzilla.novell.com/show_bug.cgi?id=623723
http://bugzilla.novell.com/show_bug.cgi?id=623723#c0 Summary: Gendarme - AvoidCodeDuplicatedInSameClassRule, AvoidCodeDuplicatedInSiblingClassesRule false positives Classification: Mono Product: Mono: Tools Version: SVN Platform: x86 OS/Version: Windows XP Status: NEW Severity: Major Priority: P5 - None Component: Gendarme AssignedTo: [email protected] ReportedBy: [email protected] QAContact: [email protected] Found By: --- Blocker: --- Created an attachment (id=377020) --> (http://bugzilla.novell.com/attachment.cgi?id=377020) debug files for repro case User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US) AppleWebKit/534.3 (KHTML, like Gecko) Chrome/6.0.466.0 Safari/534.3 This rule is marking several empty constructor implementations as being duplicates of each other. Target: JetBrains.Annotations.UsedImplicitlyAttribute Assembly: Annotations, Version=1.0.0.0, Culture=neutral, PublicKeyToken=b749b2e09cf65b7f Severity: High Confidence: Normal Location: System.Void JetBrains.Annotations.UsedImplicitlyAttribute::.ctor() Source: C:\Documents and Settings\eric.zeitler.D4\My Documents\work\SvgXaml\Annotations\Jetbrains\Annotations\Annotations.cs(≈244) Details: Duplicated code with System.Void JetBrains.Annotations.UsedImplicitlyAttribute::.ctor(JetBrains.Annotations.ImplicitUseKindFlags) Severity: High Confidence: Normal Location: System.Void JetBrains.Annotations.UsedImplicitlyAttribute::.ctor() Source: C:\Documents and Settings\eric.zeitler.D4\My Documents\work\SvgXaml\Annotations\Jetbrains\Annotations\Annotations.cs(≈244) Details: Duplicated code with System.Void JetBrains.Annotations.UsedImplicitlyAttribute::.ctor(JetBrains.Annotations.ImplicitUseTargetFlags) Additionally, simple getters are being marked as duplicates. Target: System.Windows.Threading.XmlWrappingReader Assembly: Framework4Bridge, Version=0.11.3.6001, Culture=neutral, PublicKeyToken=b749b2e09cf65b7f Severity: High Confidence: Normal Location: System.Int32 System.Windows.Threading.XmlWrappingReader::get_AttributeCount() Source: C:\Documents and Settings\eric.zeitler.D4\My Documents\work\SvgXaml\Framework4Bridge\Windows\Threading\XmlWrappingReadercs(≈140) Details: Duplicated code with System.Int32 System.Windows.Threading.XmlWrappingReader::get_Depth() Severity: High Confidence: Normal Location: System.Int32 System.Windows.Threading.XmlWrappingReader::get_LineNumber() Source: C:\Documents and Settings\eric.zeitler.D4\My Documents\work\SvgXaml\Framework4Bridge\Windows\Threading\XmlWrappingReadercs(≈235) Details: Duplicated code with System.Int32 System.Windows.Threading.XmlWrappingReader::get_LinePosition() Severity: High Confidence: Normal Location: System.String System.Windows.Threading.XmlWrappingReader::get_LocalName() Source: C:\Documents and Settings\eric.zeitler.D4\My Documents\work\SvgXaml\Framework4Bridge\Windows\Threading\XmlWrappingReadercs(≈260) Details: Duplicated code with System.String System.Windows.Threading.XmlWrappingReader::get_NamespaceURI() Finally, two methods that differ quite a bit are being marked as duplicates; I'd accept this first case if the confidence was very low as they are both the same length, take 1 arg, have a local with the same name and have a single conditional; but the second case is plainly wrong as the .ctor has no body. Target: System.Windows.Threading.XmlCompatibilityReader Assembly: Framework4Bridge, Version=0.11.3.6001, Culture=neutral, PublicKeyToken=b749b2e09cf65b7f Severity: High Confidence: Normal Location: System.String System.Windows.Threading.XmlCompatibilityReader::GetAttribute(System.String,System.String) Source: C:\Documents and Settings\eric.zeitler.D4\My Documents\work\SvgXaml\Framework4Bridge\Windows\Threading\XmlCompatibilityReader.cs(≈171) Details: Duplicated code with System.Void System.Windows.Threading.XmlCompatibilityReader::HandleChoice(System.Int32,System.Boolean&) Severity: High Confidence: Normal Location: System.Void System.Windows.Threading.XmlCompatibilityReader::.ctor(System.Xml.XmlReader,System.Collections.Generic.IEnumerable`1<System.String>) Source: C:\Documents and Settings\eric.zeitler.D4\My Documents\work\SvgXaml\Framework4Bridge\Windows\Threading\XmlCompatibilityReader.cs(≈67) Details: Duplicated code with System.Void System.Windows.Threading.XmlCompatibilityReader::HandleChoice(System.Int32,System.Boolean&) Reproducible: Always Steps to Reproduce: 1. Analysis with No Limit/High/Normal/All code Actual Results: My code has many thousands of code duplicates. Expected Results: Maybe tens of duplicates. -- Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. You are the assignee for the bug. _______________________________________________ mono-bugs maillist - [email protected] http://lists.ximian.com/mailman/listinfo/mono-bugs
