Relevant pull request: https://github.com/mono/mono/pull/5251
Mono is now the canonical home of Roslyn, and MSbuild uses the Mono-provided binaries, not its own. Sent from Outlook<http://aka.ms/weboutlook> ________________________________ From: Alexander Köplinger Sent: 02 February 2018 12:06 To: Neale Ferguson Cc: Mono Devel Mailing List; Jo Shields Subject: Re: [Mono-dev] Building mono-core Hm, that's a packaging question for Jo (added on CC). On 2 Feb 2018, at 18:03, Neale Ferguson <ne...@sinenomine.net<mailto:ne...@sinenomine.net>> wrote: What’s the proposed fix for msbuild living in –devel and msbuild? Will msbuild contain all the Roslyn stuff that can be removed from -devel? From: Alexander Köplinger <alk...@microsoft.com<mailto:alk...@microsoft.com>> Date: Friday, February 2, 2018 at 11:43 AM To: Neale Ferguson <ne...@sinenomine.net<mailto:ne...@sinenomine.net>> Cc: Mono Devel Mailing List <mono-devel-list@lists.dot.net<mailto:mono-devel-list@lists.dot.net>> Subject: Re: [Mono-dev] Building mono-core Ahh, sorry, you're talking about the mono-core.spec :D Yes, replacing .pdb there should work. I guess we can take that improvement as well? On 2 Feb 2018, at 17:41, Alexander Köplinger via Mono-devel-list <mono-devel-list@lists.dot.net<mailto:mono-devel-list@lists.dot.net>> wrote: Which %files entry are you talking about? On 2 Feb 2018, at 17:39, Neale Ferguson <ne...@sinenomine.net<mailto:ne...@sinenomine.net>> wrote: I got rid of the pdbs from the %files sections and rebuilt so the logs have been overwritten. I just replaced the %files entries that had xxxx.exe* with xxxx.* as that would work for exe/exe.so/pdb/mdb. From: Alexander Köplinger <alk...@microsoft.com<mailto:alk...@microsoft.com>> Date: Friday, February 2, 2018 at 11:36 AM To: Neale Ferguson <ne...@sinenomine.net<mailto:ne...@sinenomine.net>> Cc: Mono Devel Mailing List <mono-devel-list@lists.dot.net<mailto:mono-devel-list@lists.dot.net>> Subject: Re: [Mono-dev] Building mono-core This is the PR template that was inherited from the upstream repo, I just changed the copy in our fork :) For the PDBs: they are only generated by Roslyn csc which I think isn't the default on s390x. However, we shouldn't _require_ them anywhere, it should fallback to picking the .mdb's from mcs. Could you please post a full build log? - Alex On 2 Feb 2018, at 17:29, Neale Ferguson <ne...@sinenomine.net<mailto:ne...@sinenomine.net>> wrote: I cloned mono/boringssl, created a branch, made my changes, committed and pushed them. When I went to generate a PR: Please do not send pull requests to the BoringSSL repository. We do, however, take contributions gladly. See https://boringssl.googlesource.com/boringssl/+/master/CONTRIBUTING.md<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fboringssl.googlesource.com%2Fboringssl%2F%2B%2Fmaster%2FCONTRIBUTING.md&data=02%7C01%7Calkpli%40microsoft.com%7Ccf319b8103724694a3c608d56a5b819f%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C0%7C636531863611649124&sdata=M94cyKQ6N3qb7xJ8XS%2FLFrVe5gmMgCtztHDKO4EKoBA%3D&reserved=0> Thanks! From: Neale Ferguson <ne...@sinenomine.net<mailto:ne...@sinenomine.net>> Date: Friday, February 2, 2018 at 11:01 AM To: Alexander Köplinger <alk...@microsoft.com<mailto:alk...@microsoft.com>> Cc: Mono-Devel <mono-devel-l...@lists.ximian.com<mailto:mono-devel-l...@lists.ximian.com>> Subject: Re: [Mono-dev] Building mono-core Hey Neale, would you mind opening a pull request on GitHub with the BTLS changes for s390x? - Will do. I’ll checkout the latest copy and reapply Could you please list which pdb's it complains about? - All of them. No pdb files are created for the s390x build. What are they and how are the created? _______________________________________________ Mono-devel-list mailing list Mono-devel-list@lists.dot.net<mailto:Mono-devel-list@lists.dot.net> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.dot.net%2Fmailman%2Flistinfo%2Fmono-devel-list&data=02%7C01%7Calkpli%40microsoft.com%7C567cbcd1c9c6445403b108d56a5bd6d4%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C0%7C636531865043986428&sdata=BNnIEDEN9CBA%2B0u6728E2pNoU17%2B13mF38%2BKOJ0bL0s%3D&reserved=0
_______________________________________________ Mono-devel-list mailing list Mono-devel-list@lists.dot.net http://lists.dot.net/mailman/listinfo/mono-devel-list