Hello,
> So please tell me whether you want:
> - drop this patch
> - drop localization at all
> - or approve this patch
The patch only has one bug as it stands today: it uses a double check
lock, which is race prone:
if (x == null){
lock (...){
if (x == null){
x = Allocate ();
}
}
}
I have a few more questions: what happens if a translation does not
exist, or a catalog does not exist, do we have a fast-path?
So probably that variable needs to be allocated statically.
Also, to apply this kind of patch that will affect everything, I would
like to know in advance the memory footprint (running mono --profile
before/after should tell us this) and how much extra code is JITed at
startup (how much slower this becomes for a sample program).
Am starting to understand your point of view on the translation
technique, and it might be worth switching to the key/string translation
scheme.
Miguel.
_______________________________________________
Mono-devel-list mailing list
Mono-devel-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list
