* Is there any reason why you did not include the comments from my original
Consts.cs files?
I think it should be in there, because it helped me more that one time to
explain somebody how to use the Consts scheme in Custom Attributes.
* Moreover afaik (at least it was this way when the files were written in
the first place) it is possible to compile with no symbols specified. Your
patch breaks building in this case. Again please look at the original
Consts.cs file.
* Is the differentiation for static vs. sealed worth the #if code? Do we
gain anything by using static for .Net 2.0?
Andreas
P.S. Do you think that currently the location for the shared files is
suitable? imho it would be better for them to be in a directory in the
"class" directory. Otherwise it makes the download tarball function in a
directory absolutely useless if you just want to get the class libraries.
(This should NOT affect this NOW)
----- Original Message -----
From: "Kornél Pál" <[EMAIL PROTECTED]>
To: <[email protected]>
Sent: Thursday, August 18, 2005 2:36 AM
Subject: [Mono-dev] [PATCH] Assembly version 2.0.0.0 with
centralizedassembly references
Hi,
This patch is quite big. The 2.0.0.0 patch was much smaller but you wanted
this bigger one.:) It may be more difficult to review but will result in a
much reliable class library.
It contains only assembly version related things nothing else. Note that I
corrected all the version issues I found in any file type. For example:
v2.0.40607 -> v2.0.50215 (config)
1:0:33000:0 -> 1:0:3300:0 (comment)
1.0.3102.0 -> 1.0.3300.0 (resx)
I did not modify any InformationalVersion or FileVersion attributes but
they
should be modified at a later time.
I did not modified tests to use the common Consts.cs because they are
designed differently but I updated the version numbers to 2.0.0.0.
I did not added any ChangeLog entry and I'm not going to do it by hand. If
you want to have ChangeLog entries please let me know how can I generate
them.
To Ben:
I am sick of explaining that this task is in fact quite easy.
The idea behind this task is easy to understand but actually it took a lot
of hours to create this patch as all the results has to be examined even
with regular expressions matching only the right version numbers.
Kornél
--------------------------------------------------------------------------------
_______________________________________________
Mono-devel-list mailing list
[email protected]
http://lists.ximian.com/mailman/listinfo/mono-devel-list
_______________________________________________
Mono-devel-list mailing list
[email protected]
http://lists.ximian.com/mailman/listinfo/mono-devel-list
