Just looked over it briefly:
if (assemblyName == "")
is better to be value.Length == 0 (used more than one time)
+ assemblyName = assemblyName.Replace (" ", "");
Is this correct? Shouldn't it be .Trim?
+ if (String.Compare (parts [i], 0, "Version=", 0, 8, true,
CultureInfo.InvariantCulture) == 0)
This is most likely incorrect and needs to use an ordinal comparison, no
InvariantCulture (used more than one time)
Greets
Andreas
----- Original Message -----
From: "Carlos Alberto Cortez" <[EMAIL PROTECTED]>
To: "Mono Devel" <[email protected]>
Sent: Friday, August 19, 2005 10:49 AM
Subject: [Mono-dev] [Patch] AssemblyName ctor
Hey,
The patch attached implements the new AssemblyName ctor without using
internal calls. Could anybody review it?
Carlos.
--------------------------------------------------------------------------------
_______________________________________________
Mono-devel-list mailing list
[email protected]
http://lists.ximian.com/mailman/listinfo/mono-devel-list
_______________________________________________
Mono-devel-list mailing list
[email protected]
http://lists.ximian.com/mailman/listinfo/mono-devel-list
