Hi,

Right.:) But I posted a modified version in the response (the list is CC) to Miguel's objections because I forgot to deal with the index parameter. And this unnecessary unsafe marker is removed from that updated version. The message also includes a performance comparsion.

Kornél

----- Original Message ----- From: "Zac Bowling" <[EMAIL PROTECTED]>
To: "Kornél Pál" <[EMAIL PROTECTED]>
Cc: <[email protected]>
Sent: Wednesday, June 07, 2006 6:38 PM
Subject: Re: [Mono-dev] [PATCH] Speed up ByteEncoding.GetString()


Cute. The second function doesn't look like it needs to be marked unsafe
though.

On Tue, 2006-06-06 at 23:32 +0200, Kornél Pál wrote:
Hi,

ByteEncoding.GetString() currently uses StringBuilder that is very slow. I
modified it to use InternalAllocateStr and unsafe code that makes is much
faster.

Please review and approve the patch.

Kornél
_______________________________________________
Mono-devel-list mailing list
[email protected]
http://lists.ximian.com/mailman/listinfo/mono-devel-list
--
Zac Bowling <[EMAIL PROTECTED]>


_______________________________________________
Mono-devel-list mailing list
[email protected]
http://lists.ximian.com/mailman/listinfo/mono-devel-list

Reply via email to