-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Oct 15, 2007, at 2:14 AM, Konstantin Triger wrote: > Hey Tyler, > > 1. Your code must come AFTER 'if (type == null)' for obvious reasons. > The best place would be just before 'return Convert.ChangeType (obj, > type);' at the end of the function. > > 2. Please add the following test cases (passing on MS .Net): > Converting to Nullable<> from empty and non-empty strings. I went ahead and committed in r 87847 (and r 87848 because I'm an idiot and forgot to move the code down and only realized after I checked with null >_<) Anyways, I'm a bit unsure where I should commit the test, I'm assuming in System.Web.Extensions/Test/ System.Web.Script.Serialization/JavaScriptSerializer.cs? I'm just unsure because I see gert commit tests like a madman elsewhere :-P Cheers, - -R. Tyler Ballance -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) iD8DBQFHGexDA2GmJ0VpG78RAjwtAJ4pq1cZsYNbDBSDUhHnhUvI5HKoBwCfX5Hm XaI/yQu+6Hi3erorUm1hS60= =jmcq -----END PGP SIGNATURE----- _______________________________________________ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list