The _MonoMethod struct is instantiated too many times on during runtime to have information added to it. The extra space would cause a huge overhead.
The other issue is that the way it's doing is resolving too much metadata information. It should be done as lazily as possible. I have a similar need that I'm coding right now, once I add the required code to do so, your patch will get a lot simpler. On Mon, Jan 19, 2009 at 5:47 PM, crashfourit <[email protected]> wrote: > > > > Rodrigo Kumpera wrote: > > > > This is the wrong approach to check for the assembly, you should first > > strcmp > > for it and only after that cache the result. Don't load the assembly if > > it's > > possible to avoid so. > > > > On Mon, Jan 19, 2009 at 8:04 AM, crashfourit <[email protected]> > > wrote: > > > >> > >> Here is my updated patch. > >> > >> http://www.nabble.com/file/p21539945/trunk_mono.diff trunk_mono.diff > >> > >> What do you think? > >> -- > >> View this message in context: > >> http://www.nabble.com/mono-inlining-tp21510132p21539945.html > >> Sent from the Mono - Dev mailing list archive at Nabble.com. > >> > >> _______________________________________________ > >> Mono-devel-list mailing list > >> [email protected] > >> http://lists.ximian.com/mailman/listinfo/mono-devel-list > >> > > > > _______________________________________________ > > Mono-devel-list mailing list > > [email protected] > > http://lists.ximian.com/mailman/listinfo/mono-devel-list > > > > > Here is another updated patch. > Hope it is to your liking. > http://www.nabble.com/file/p21550206/trunk_mono.diff trunk_mono.diff > -- > View this message in context: > http://www.nabble.com/mono-inlining-tp21510132p21550206.html > Sent from the Mono - Dev mailing list archive at Nabble.com. > > _______________________________________________ > Mono-devel-list mailing list > [email protected] > http://lists.ximian.com/mailman/listinfo/mono-devel-list >
_______________________________________________ Mono-devel-list mailing list [email protected] http://lists.ximian.com/mailman/listinfo/mono-devel-list
