Hello, Few comments from me
- All code is #if NET_4_0 there is no need for further nested #if - Why did you have to introduce private exception classes ? Marek >> >> >>> -----Ursprüngliche Nachricht----- >>> Von: mono-devel-list-boun...@lists.ximian.com [mailto:mono-devel-list- >>> boun...@lists.ximian.com] Im Auftrag von Chris Bacon >>> Gesendet: Mittwoch, 16. Juni 2010 12:03 >>> An: Marek Safar >>> Cc: mono-devel-list@lists.ximian.com >>> Betreff: Re: [Mono-dev] Patch 1/2 - System.Diagnostics.Contracts in >>> corlib >>> >>> Hi, >>> >>> Attached is a new, improved, patch that keeps existing formatting. >>> Sorry for the mistake. >>> >>> Kind regards >>> Chris >>> >>> Marek Safar wrote: >>> >>>> Hi Chris, >>>> >>>>> Attached is a patch to corlib containing updates the >>>>> System.Diagnostics.Contracts as part of the GSoC work I am doing. >>>>> >>>>> I'm sure there will be parts of this I haven't done quite right, so >>>>> please let me know what they are, and I'll sort them out. >>>>> >>>> Can you keep existing formatting, most of the changes are about >>>> changing tabs to spaces. Please send a new set of patches without any >>>> noise (lines you have not changed) >>>> >>>> Thanks >>>> Marek >>>> >> >> _______________________________________________ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list