Patch 4 is in (https://github.com/mono/mono/commit/ecd410269466799c8bde71fc55ea9bf2a052c364). Cheers.
I'll spend some more time on patch 1 to see if I can figure out what's wrong. Steven Boswell II wrote > > Maybe you're running an older version of my unit test, before I added code > that ensured the event-handler was being called. I've attached a fresh > copy of patch #1. > > Enclosed is a reworked version of patch #4, one whose behavior has been > tested against .NET. Apply the unit test patch, see that you get a unit > test failure, then apply my patch, and see that the unit test no longer > fails. Also enclosed is a ComboBoxTest project containing the unit test, > so you can run it under .NET easily. > > Also, I noticed that bringing up a dialog box before calling > Application.Run() tends to make Mono freak out. Maybe that's the problem > with your DgwTest project? The enclosed ComboBoxTest project waits until > the Form's Load event to bring up dialog boxes. > > I will go and redo patch #3 so that it works under .NET, and try to come > up with unit tests for patches 2 and 7. Those require user > interaction...if I can figure out how to fake a mouse click, I should be > able to do this. Looks like the accepted method is to create a subclass > and then call OnMouseClick() directly. > > Steven Boswell > > > ________________________________ > From: Stifu <stifu@> > To: [email protected] > Sent: Saturday, June 9, 2012 9:34 AM > Subject: Re: [Mono-dev] Patches for mono-winforms > > "Um...you're not supposed to get the "Event handler!" message-box with an > unpatched Mono. The patch's main purpose is to make sure that event > handler > gets called. Or do I misunderstand what you're saying?" > > Then isn't the test wrong? If the event handler doesn't get executed, then > the unit test still passes. I just tried commenting the event handler and > run the test with .NET, and it passes. > > By the way, I think there may have been issues with patch 3... Now the > concerned 2 tests (SelectedColumnsTest and SelectedRowsTest) don't pass > anymore with .NET, it seems. > > I get: 1-14 > Expected: 0 > But was: 2 > > Can you confirm? I did stumble across this error while reviewing your > patch, > but then I thought it ended up passing. I must have made a mistake > somewhere. > > I didn't actually find your GitHub account, just referenced your e-mail > address and that's it. :p > C# Qt bindings is a cool project. I was gonna mention CXXI, but you > already > know about it. > > > Steven Boswell II wrote >> >> Um...you're not supposed to get the "Event handler!" message-box with an >> unpatched Mono. The patch's main purpose is to make sure that event >> handler gets called. Or do I misunderstand what you're saying? >> >> Thanks for committing my other patch. I had totally forgotten about my >> account on GitHub. Kudos for finding it. :-) >> >> Steven Boswell >> >> >> ________________________________ >> From: Stifu <stifu@> >> To: [email protected] >> Sent: Saturday, June 9, 2012 12:03 AM >> Subject: Re: [Mono-dev] Patches for mono-winforms >> >> By "ran fine", do you mean you do get the "Event handler!" message box? >> Because I don't, with Mono (unpatched). >> >> Patch 8 pushed, slightly reformatted >> (https://github.com/mono/mono/commit/641ae7303320c2bad8ff83f9b5f9fc0d285b6b0e). >> Thanks. >> _______________________________________________ >> Mono-devel-list mailing list >> [email protected] >> http://lists.ximian.com/mailman/listinfo/mono-devel-list >> > > -- > View this message in context: > http://mono.1490590.n4.nabble.com/Patches-for-mono-winforms-tp4649620p4649820.html > Sent from the Mono - Dev mailing list archive at Nabble.com. > _______________________________________________ > Mono-devel-list mailing list > [email protected] > http://lists.ximian.com/mailman/listinfo/mono-devel-list > _______________________________________________ > Mono-devel-list mailing list > [email protected] > http://lists.ximian.com/mailman/listinfo/mono-devel-list > -- View this message in context: http://mono.1490590.n4.nabble.com/Patches-for-mono-winforms-tp4649620p4649826.html Sent from the Mono - Dev mailing list archive at Nabble.com. _______________________________________________ Mono-devel-list mailing list [email protected] http://lists.ximian.com/mailman/listinfo/mono-devel-list
