My guess is that its probably worth the extra hour to handle the #elif and #else conditions. I imagine there are a bunch of places with
#ifdef NET_2_0 #else #endif I wouldn't go crazy on it but a few days of manually fixing those would be annoying :) On Wed, Oct 22, 2014 at 11:10 PM, Miguel de Icaza <mig...@xamarin.com> wrote: > Hey Alex, > > It is very repetitive work, so what I wanted to do was to write a perl > script to remove the *obvious* ifdefs. The tool would remove only those > that match the following criteria (more or less): > > Remove toplevel #if NET_2_0 with the final #endif > Only remove those that contain those preprocessor directives > > And then have a human do the more fine-tuned approach. There are a > couple more defines that I remember could be automated, but I would love to > have this in the form of a script. > > I am afraid of applying a patch like that blindly, because there are no > exact guarantees of what happened without reviewing the whole file. So a > script with the invariants would take a lot of my nervousness out. > > Also, when I did it once, I had a setup where I rebuilt the assemblies and > compared the output. This would ensure that removal of ifdefs did not > change the resulting binaries. > > On Wed, Oct 22, 2014 at 4:04 PM, akoeplinger <alex.koeplin...@outlook.com> > wrote: >> >> Sounds like a good thing ;-) >> >> I've got a branch in my fork where I removed the NET_2_0 ifdefs: >> https://github.com/akoeplinger/mono/compare/remove-net20-ifdefs, @kumpera >> told me a while ago that removing the 2.0 profile is on the horizon when I >> asked about why the ifdefs are still there. >> >> I refrained from making a PR so far because it is quite huge, do you think >> now would be a good time? >> >> -- Alex >> >> >> >> -- >> View this message in context: >> http://mono.1490590.n4.nabble.com/Heads-up-Elimination-of-the-2-0-and-4-0-profiles-tp4664323p4664325.html >> Sent from the Mono - Dev mailing list archive at Nabble.com. >> _______________________________________________ >> Mono-devel-list mailing list >> Mono-devel-list@lists.ximian.com >> http://lists.ximian.com/mailman/listinfo/mono-devel-list > > > > _______________________________________________ > Mono-devel-list mailing list > Mono-devel-list@lists.ximian.com > http://lists.ximian.com/mailman/listinfo/mono-devel-list > -- Studying for the Turing test _______________________________________________ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list