Thanks, for your help! I only had a problem getting it downloaded since the link at the site you posted was corrupted. Had to replace the ftp:// against http:// wich worked ;)
Tobias From: [email protected] [mailto:[email protected]] On Behalf Of Stéphane Zanoni Subject: Re: [Mono-list] Bug in RFCFilter in Namespace Novell.Directory.Ldap.Rfc2251 We use the NLDAP-C# quite heavily. As an FYI, the NLDAP-C# was created by Novell (~2003) in a different repository around the time Ximian was acquired. The version of NLDAP-C# in the mono repo was forked and had some Java "stuff" added to it. Not all of the bug fixes added to the Novell repo made it back into the mono repo after the fork. The mono repo could use a refresh. An example of that is your reported bug. It does not exist in the Novell copy. Comparing the Mono SVN copy of the code to the Novell CVS repository... Array.Copy((System.Array) SupportClass.ToByteArray(utf8Bytes), 0, (System.Array)SupportClass.ToByteArray( octets), iOctets, utf8Bytes.Length); to Array.Copy((System.Array) (utf8Bytes), 0, (System.Array) octets, iOctets, utf8Bytes.Length); As for the C# naming guidelines... the entire project source is fubared.... probably best to leave alone. You can find the Novell copy here and perform a sync to take the bits you want. http://developer.novell.com/wiki/index.php/LDAP_Libraries_for_C_sharp Stéphane >>> Stifu <[email protected]> 2010.04.28 12:00 PM >>> Nitpicking: the unescapeString method should have an uppercased U (to follow the C# naming guidelines), so you might want to fix that while you're there. On the other hand, maybe the concerned class contains other methods cased this way, so there may be more to fix... *shrugs* By the way, personally, I use the diff command through cygwin in order to generate patches, and I think TortoiseSVN generates patches in the exact same format. Actually, I'll start doing it through TortoiseSVN from now on, it's easier. :) -- View this message in context: http://mono.1490590.n4.nabble.com/Bug-in-RFCFilter-in-Namespace-Novell-Directory-Ldap-Rfc2251-tp2073517p2073710.html Sent from the Mono - General mailing list archive at Nabble.com. _______________________________________________ Mono-list maillist - [email protected] http://lists.ximian.com/mailman/listinfo/mono-list _______________________________________________ Mono-list maillist - [email protected] http://lists.ximian.com/mailman/listinfo/mono-list
